From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#18426: [PATCH] Increase default size of imenu-auto-rescan-maxout Date: Thu, 30 Aug 2018 16:55:38 -0500 Message-ID: <877ek7frj9.fsf@gmail.com> References: <878t4nfrz7.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535667000 7907 195.159.176.226 (30 Aug 2018 22:10:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 30 Aug 2018 22:10:00 +0000 (UTC) User-Agent: mu4e 1.0; emacs 26.1 To: 18426@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 31 00:09:56 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvV8V-0001xU-L2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Aug 2018 00:09:55 +0200 Original-Received: from localhost ([::1]:51064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvVAc-0001Sb-1D for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Aug 2018 18:12:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvV7a-0007fR-0t for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 18:09:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fvUv4-0007s7-Qt for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 17:56:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34505) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fvUv4-0007rs-MM for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 17:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fvUv4-0005p3-IF for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2018 17:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Aug 2018 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18426-submit@debbugs.gnu.org id=B18426.153566614822360 (code B ref 18426); Thu, 30 Aug 2018 21:56:02 +0000 Original-Received: (at 18426) by debbugs.gnu.org; 30 Aug 2018 21:55:48 +0000 Original-Received: from localhost ([127.0.0.1]:39523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvUuq-0005oa-5I for submit@debbugs.gnu.org; Thu, 30 Aug 2018 17:55:48 -0400 Original-Received: from mail-oi0-f66.google.com ([209.85.218.66]:44217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvUuo-0005oN-2K for 18426@debbugs.gnu.org; Thu, 30 Aug 2018 17:55:46 -0400 Original-Received: by mail-oi0-f66.google.com with SMTP id l82-v6so18205779oih.11 for <18426@debbugs.gnu.org>; Thu, 30 Aug 2018 14:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=3w6zD5RHteTXSyOeUWvRyHbyIjQhgxv0G6xvXS6ys/I=; b=EvQ6Fw/UY0NJXEL2O103cyuFUb5fJK3idIcVZble2u4AJTIVd9afsT7XXFOzGmiBVn LxRF0lhGiuF0/zHZEEXUjtXrm/7akrxfVnhxbo0HMSE5WcdUq2QsX3+TwxXBJ5OojsX5 sWQ/DiU1VAiCH1GmkSaoa2+yJfB1pNWQJy8lQkPx/OI2Wo688xI4Th70u5fwXK44n4kx /64eRKVGl2LjxPiHLGfXTihVcOTLCCexFSQaJnZQmfjIjci/M0kUlW/08P9NTSPo6+Eu LhG8Z9umgKxNNI6bcIJRY3RVZ9R/Xb1e8o7PFK0AzU23cbpDncyqEQHp9YKuIEcJaxzY U7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=3w6zD5RHteTXSyOeUWvRyHbyIjQhgxv0G6xvXS6ys/I=; b=S84mhYmPeAPvM4CvnMGt2ED8VJL4027Pxj2oGqwXoOlKbTweHemuwqjpdDiQI3rm5v 6IZlSOJLQM4Rw5+WShwvg+6MU14W7p0qpp/w8bgWyP3mM7iMWyxDhpSEyaURX6Guf8Io 4Mh0j1XS2DRBUnv9r68tse4bJLDVeST8pdWe2qqCPUmP9ebi/5FrZcSUOimxsERI20jD EpsYv/XyTuYxx91tb8anp2Z1/AslvjKDVJjF3MQPGm5xo9xQCriqdIfiUc8Y82QMMSJu NGLQ+BMGeJz+DSQ0BdnY+XqsxwUutWdtGsLZive+87F8mGadosl63Ze6wD/DMC0JedIu 4sNQ== X-Gm-Message-State: APzg51CKxvcOLJS7O9tTMlVcwUoYuOzj5/sze71W9o3wC7J743simiOR G651tTGeKveHu0Nm+zqFPjm/D3oy X-Google-Smtp-Source: ANB0VdavB3sY9ytf9+rsWvXdxkh5rYCiG2bM8hWClI4FuOJsF8XMAr3UCkVZWNf1DZDlnp/5nwSnAw== X-Received: by 2002:aca:5155:: with SMTP id f82-v6mr4235301oib.272.1535666140110; Thu, 30 Aug 2018 14:55:40 -0700 (PDT) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id o125-v6sm13038922oig.44.2018.08.30.14.55.39 for <18426@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 14:55:39 -0700 (PDT) In-reply-to: <878t4nfrz7.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149896 Archived-At: Here's a patch that includes some text for the manual. I'm not sure of the right way to submit this since the patch I send would go into 27.1 (I assume?), but this is a manual update that could go into the emacs-26 branch: Thanks again, Alex --- diff --git a/doc/emacs/programs.texi b/doc/emacs/programs.texi index c72558ce9a..cfeb61e44d 100644 --- a/doc/emacs/programs.texi +++ b/doc/emacs/programs.texi @@ -274,6 +274,10 @@ Imenu a non-@code{nil} value. There is no need to rescan because of small changes in the text. +@vindex imenu-auto-rescan-maxout + @code{imenu-auto-rescan} will be disabled in buffers that are larger +than @code{imenu-auto-rescan-maxout} in bytes. + @vindex imenu-sort-function You can customize the way the menus are sorted by setting the variable @code{imenu-sort-function}. By default, names are ordered as On Thu 30 Aug 2018 at 16:46, Alex Branham wrote: > I just ran into this issue that was originally reported 4 years ago. > Here's a patch that increases the default size of > imenu-auto-rescan-maxout by a factor of 10 like Stefan suggested, though > honestly we could probably increase it past this even. > > I also removed the doc about it being a buffer-local variable because > it's not AFAICT. > > This doesn't need a NEWS entry, right? > > Thanks, > Alex > > > --- > > > From c3a820f680a5b65e946f300709e0fac0bf9420ba Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Thu, 30 Aug 2018 16:41:37 -0500 > Subject: [PATCH] * lisp/imenu.el (imenu-auto-rescan-maxout): Increase default > size > > Closes bug#18426 > --- > lisp/imenu.el | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lisp/imenu.el b/lisp/imenu.el > index 7285b10574..e67dabed7d 100644 > --- a/lisp/imenu.el > +++ b/lisp/imenu.el > @@ -96,11 +96,11 @@ imenu-auto-rescan > :type 'boolean > :group 'imenu) > > -(defcustom imenu-auto-rescan-maxout 60000 > - "Imenu auto-rescan is disabled in buffers larger than this size (in bytes). > -This variable is buffer-local." > +(defcustom imenu-auto-rescan-maxout 600000 > + "Imenu auto-rescan is disabled in buffers larger than this size (in bytes)." > :type 'integer > - :group 'imenu) > + :group 'imenu > + :version "27.1") > > (defcustom imenu-use-popup-menu 'on-mouse > "Use a popup menu rather than a minibuffer prompt. > -- > 2.18.0 > From c3a820f680a5b65e946f300709e0fac0bf9420ba Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Thu, 30 Aug 2018 16:41:37 -0500 > Subject: [PATCH] * lisp/imenu.el (imenu-auto-rescan-maxout): Increase default > size > > Closes bug#18426 > --- > lisp/imenu.el | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lisp/imenu.el b/lisp/imenu.el > index 7285b10574..e67dabed7d 100644 > --- a/lisp/imenu.el > +++ b/lisp/imenu.el > @@ -96,11 +96,11 @@ imenu-auto-rescan > :type 'boolean > :group 'imenu) > > -(defcustom imenu-auto-rescan-maxout 60000 > - "Imenu auto-rescan is disabled in buffers larger than this size (in bytes). > -This variable is buffer-local." > +(defcustom imenu-auto-rescan-maxout 600000 > + "Imenu auto-rescan is disabled in buffers larger than this size (in bytes)." > :type 'integer > - :group 'imenu) > + :group 'imenu > + :version "27.1") > > (defcustom imenu-use-popup-menu 'on-mouse > "Use a popup menu rather than a minibuffer prompt.