From: Michael Heerdegen <michael_heerdegen@web.de>
To: 33341@debbugs.gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#33341: 27.0.50; Undo log merging and change groups
Date: Sun, 11 Nov 2018 08:50:43 +0100 [thread overview]
Message-ID: <877ehk3ve4.fsf@web.de> (raw)
Hello,
I have been playing with the undo change group functions. I found
`cancel-change-group' does not always work as expected. For example, if
you define
(defun my-test-change-groups ()
(interactive)
(insert "0\n")
(let ((g (prepare-change-group)))
(activate-change-group g)
(insert "b\n")
(insert "c\n")
(cancel-change-group g)))
and call that command in some random buffer, the final
`cancel-change-group' has no effect (i.e. nothing is reverted). In
other, similar examples, `cancel-change-group' seems to revert more than
it should.
To cite (CC'd) Stefan's remark in emacs-help, "the undo entries for
(insert "0\n"), (insert "b\n"), and (insert "c\n") are merged into a
single entry in the undo log (as a form of optimization). The
change-group code should prevent such a merge, e.g. by adding some dummy
undo element which will work like a "fence"".
Thanks,
Michael.
In GNU Emacs 27.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.24.1)
of 2018-11-11 built on drachen
Repository revision: c1095b03a933d55fe1cd357881f1ca6e16e06362
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description: Debian GNU/Linux buster/sid
next reply other threads:[~2018-11-11 7:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 7:50 Michael Heerdegen [this message]
2020-11-26 12:34 ` bug#33341: 27.0.50; Undo log merging and change groups Lars Ingebrigtsen
2020-11-26 14:16 ` Michael Heerdegen
2020-11-26 14:49 ` Michael Heerdegen
2020-11-26 20:26 ` Michael Heerdegen
2020-11-26 20:55 ` Stefan Monnier
2020-11-27 1:11 ` Michael Heerdegen
2020-11-27 14:44 ` Stefan Monnier
2020-11-27 17:43 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ehk3ve4.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=33341@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.