From: Michael Albinus <michael.albinus@gmx.de>
To: Daniel Pittman <slippycheeze@google.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations.
Date: Tue, 02 Apr 2019 15:18:55 +0200 [thread overview]
Message-ID: <877ecczgsg.fsf@gmx.de> (raw)
In-Reply-To: CAC45yQvOAV0f-GvjmaeE35W8dL9XDDVCV7q1Z+Own+393z4WQA@mail.gmail.com
Daniel Pittman <slippycheeze@google.com> writes:
Hi Daniel,
> Yes. Tramp fights indeed with timers, and so I have disabled
> timers in tramp-accept-process-output already. Maybe we shall do
> the same in tramp-send-string? Would the following patch help?
>
> In brief testing – 100 percent reproducible error, but only one
> instance – this patch did fix the problem.
Thanks for testing! I've pushed the patch, slightly extended, to the
repositories.
> I haven't tried to provoke a non-local exit from anything contained
> within, or anything like that, since you obviously omitted the code
> for that in this test patch.
Good catch. I've wrapped process-send-string by with-local-quit, as I
did already with accept-process-output. The other errors shall be
handled by the Tramp machinery.
> So, yeah, I think that is sufficient.
Please continue to stress Tramp, and report problems. Much appreciated!
Best regards, Michael.
prev parent reply other threads:[~2019-04-02 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 15:38 TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations Daniel Pittman
2019-03-27 15:55 ` Michael Albinus
2019-03-27 16:22 ` Daniel Pittman
2019-03-27 17:49 ` Michael Albinus
2019-03-29 12:36 ` Daniel Pittman
2019-03-29 17:03 ` Michael Albinus
2019-04-02 9:34 ` Daniel Pittman
2019-04-02 13:18 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ecczgsg.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=slippycheeze@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.