From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Renaming non-X x_* identifiers Date: Tue, 16 Apr 2019 11:07:53 -0600 Message-ID: <877ebtdgk6.fsf@gmail.com> References: <87wokp4okn.fsf@gmail.com> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com> <831s2nhza8.fsf@gnu.org> <87d0lpvq6n.fsf_-_@gmail.com> <83r2a5keo7.fsf@gnu.org> <87pnppu4ox.fsf@gmail.com> <83muktk9xb.fsf@gnu.org> <875zrhtg2i.fsf@gmail.com> <83ftqkk7lr.fsf@gnu.org> <877ebwvatg.fsf@gmail.com> <83y34cin3g.fsf@gnu.org> <87y34ctrs1.fsf@gmail.com> <83h8azianr.fsf@gnu.org> <87r2a3jh5h.fsf@gmail.com> <83y34bgldk.fsf@gnu.org> <87k1ftdiky.fsf@gmail.com> <83wojtgaqv.fsf@gnu.org> <87bm15dgyk.fsf@gmail.com> <83v9zdg9uf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="119103"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: alan@idiocy.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 19:08:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGRYx-000UsR-7C for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 19:08:03 +0200 Original-Received: from localhost ([127.0.0.1]:39819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRYw-0007ya-7D for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 13:08:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRYq-0007yU-Jp for emacs-devel@gnu.org; Tue, 16 Apr 2019 13:07:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGRYp-0004P7-Nz for emacs-devel@gnu.org; Tue, 16 Apr 2019 13:07:56 -0400 Original-Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:43468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGRYp-0004OP-FF; Tue, 16 Apr 2019 13:07:55 -0400 Original-Received: by mail-pl1-x62d.google.com with SMTP id n8so10624712plp.10; Tue, 16 Apr 2019 10:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nVDPZn/jjDkkgIwkyOD65gzXIBt+XILR/gNyGTFxxY8=; b=DoIpPE41+g+bzal4wIvAM9VLDGGUHreQkaRmFOqVK9BADKvzxjMRo79opAFujdVrLK lQ8CdLE6U6BoKwl8wSnXN0Rt+2RB7TJOcl13V6CDBT2maG3WlK7qHJhgV+YBExoNIyvG vtzayt+hIxJcV/NWuPLqrnX7iLSEz5lLxx4tP9GK6yzQ1APKWZ18pKRpMGAF0GsB7HI2 kAbYMd4+YUThy7ZxmLV1GLSCZX5r1DWELx2b5CCMhR4R3GBZ9lk1PVwOrrpLYOlDT6WK E4mI9D+p18otaIbAj8ZfwsoVi5/mwukfCCwMoPzG9EdVzB7NPU91AhXeAjlYqnmV0pvI 8OKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nVDPZn/jjDkkgIwkyOD65gzXIBt+XILR/gNyGTFxxY8=; b=doO5ACWoT4iLM68BJzUMG6XcdC4dt6JKg/BAOmf7Y8JtsElCQU9qAIPt2L1mYIAX4M HsB3vlwd5jfPPmVcW51WY++qL0DVYwgU6TskiWen43EVkwGXFjzXJgJ7W8jffOtFZ2xf FEmfCnfmQJNeW+XFn3tIgJ9CRclM7jcDFTgo27sU4rXEWdAqIkLnVMigQd53He+F31gp 3IBLHliMw+d3HcCEmfqe/4BC2SDFHToWCsyZfcMjWGhBH/9jKUga25kUs1Cmzh02Ssfg zNjVOMko3iCSNXxEDKunYPYAGqFC7v7uOyx9Ddp44R0dHhsezMOBRgMmWacjglr+0mEP baUA== X-Gm-Message-State: APjAAAVIgGcBTp66VDdHW4dNG843LIN95X7bYsh6y1CLTrlXhGmcCkfc JyDWNc6uGyY2r3yzcJWcnh0= X-Google-Smtp-Source: APXvYqzu9PXqUhC9wfgJQiPt5Bov/U1jbXZYv4Ga21qtUekNtudrgZRZKvK84fy0j6UPjMd3MvGFvg== X-Received: by 2002:a17:902:e287:: with SMTP id cf7mr55796715plb.217.1555434473472; Tue, 16 Apr 2019 10:07:53 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id m25sm70662531pfa.175.2019.04.16.10.07.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 10:07:52 -0700 (PDT) In-Reply-To: <83v9zdg9uf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Apr 2019 20:04:40 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235538 Archived-At: Eli Zaretskii writes: >> From: Alex Gramiak >> Cc: emacs-devel@gnu.org, alan@idiocy.org >> Date: Tue, 16 Apr 2019 10:59:15 -0600 >> >> Finally, what would you like me to do with the "Rename non-X x_* >> identifiers" and "Rename non-X x_* identifiers 2" patches? Should I >> split them up further, or is it okay to squash them into a single patch? > > Hmm... I don't think I understand which patches are you talking > about. Can you point me to the respective messages in the list > archives? I'm referring to the commits named "Rename non-X x_* identifiers"* in scratch/x_emacs. Specifically commits 09fd8e70a0 and e7c3d39925. I left the two commits separated until now since I wasn't sure whether a single larger patch would be preferred/accepted.