From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Thu, 09 May 2019 13:50:06 +0200 Message-ID: <877eazx2xd.fsf@gmx.de> References: <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="74008"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 09 13:51:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOhZy-000J5w-He for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 May 2019 13:51:14 +0200 Original-Received: from localhost ([127.0.0.1]:52881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOhZx-0003ij-GP for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 May 2019 07:51:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOhZo-0003id-E7 for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 07:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOhZn-0004DR-6h for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 07:51:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49530) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOhZn-0004DL-35 for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 07:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOhZm-0004Lk-Ip for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 07:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2019 11:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155740262316671 (code B ref 35418); Thu, 09 May 2019 11:51:02 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 9 May 2019 11:50:23 +0000 Original-Received: from localhost ([127.0.0.1]:34841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOhZ7-0004Kn-UG for submit@debbugs.gnu.org; Thu, 09 May 2019 07:50:23 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:36237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOhZ5-0004Ka-4R for 35418@debbugs.gnu.org; Thu, 09 May 2019 07:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557402608; bh=6qZZRFk3yxAuqJgyNa6YG+eaEVVHtaJj0D3Oaz92j6E=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=OUnYW57Ye58/5Z2bxxBZ23ZOX01tAq7Z6YOHPGnTMR5xPsL89iBUCBmDK2BH4lPus JxmrcL+liJ9evJpS8qJCrDjeqXuNzQzYSVjjmlMG6p7z/bP2ucMmE6etPtwJ+tIvX0 9hv7xaCP7sJlgxdCyvX64FAFyR5VYf/BxbZyOHiQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([178.20.95.22]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mc9U3-1h6thH2YNz-00JakS; Thu, 09 May 2019 13:50:08 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Wed, 8 May 2019 13:48:51 +0200") X-Provags-ID: V03:K1:h1ZqD5xranxO7qGQxtaC6V/tWbC7id/8OLTH2dFqARCq64q7bnl auA2+JcbK/FAaz7hIURM9PIwu5r0pYjdVRMNBOuetkkHcBB2oA30m7Y3z0ivaNCx4laWqNC UqUyTpNbcwvYVI77tYXomOGnNpy3mTubM34kLjbuFZaaa5O9MoYjn11n2x42ws96cARBRs8 bkR6CXmc4AIMZi+KBVHQQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:rOiKvzuT5A4=:HPQZgq5QUuHaTpJLdyx5gR MkeXiIYvAlOwwelRqM+24F7g8j5kHRX06eshi6zAYWlq27hFFMl6IMsOO5s6Ho9ISCGxsASiu bRiEtSjcIIv5ITP+55V1na4a4UewblATABnE7VcoiXMBZyzgb/v2DwhCcAL1Vdc+e345kZxYj VHdAei8uucNbqX5A9aalUD4qm8kDmmKh/KdNKVc2sGGlZdDJ7XrxaFAzi/U1+CMr1vWHg2knE Y0BfV/802JomhYTZbm0TLp2DbObUZt3yfkzf/uXgjHPo3l0aEHibuZNt0ORIspWdv/CcqGfp5 qPsYSHmY3S/cGLpcNPggX+4nd/NWkhsuwxPwEVFuN8Ad/fu2EXJEtgywxXoFIyNSCz+Ya88Sa dKw52WqK7PgP+0gucRKm68wBjGXchdSlpDxIkSHa/b/pajGN+yHmbwz2YnZPxAKDcKLtYl6dG BLGsbfnSzu/NB/Y5a8JP5UTrzQUu9Ripo0mAveSQ8pkFG5Ztl3qd3Ibt1cILBGO0EOEo3Koih Nz+Y5URxMpk3rMPFw7cncF2CvOFCucJx8D9OTsitNXm0leM/PliVOLL9Jn9wzMSwiGRY1ha9i lYueIZdp5m6S7+jC3DZz4kDqwpeffEfbRmx1EB/iz+Uo4yZNlg0nQxkoh08MJKzoaI+cPIA0q sulNZvA11H5huiWQaHtsEQTMdxbrfdktoXnaGYKdTdVKDPv5sGKsRNf7pQ0CvRGMWNJkP227B 6Rtf6JmCNtGwD67VcxlVCPfm1ho85mogSOGcWp0lltexgTj97kkzxBlwBBJH+k6XPytE0nGj X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158980 Archived-At: Mattias Engdeg=C3=A5rd writes: Hi, > An example of a generalisation: We could add a buffer-specific > variable that tells autorevert that yes, this buffer can rely on > directory notifications despite not having a buffer-file-name. All > modes to which this applies would need to set that variable. I sympathize with this proposal. There shall be an indication that a buffer could be auto-reverted by file notifications. This indication is either a non-nil buffer-file-name, or a non-nil buffer-local variable (let's call it buffer-auto-revert-by-file-notification-aware; I'm open to any better name). Non-file buffers which could be auto-reverted are those which provide a buffer-stale-function. A short scan in vanilla Emacs shows Buffer-menu-mode and dired-mode, which set buffer-stale-function. Buffer-menu-mode does not use files, so it doesn't profit from file notifications. One could write another kind of notification which fires when buffers are created or deleted, but that's another story. And I doubt it will be more useful than the current auto-reverting for buffer lists. So indeed, dired is left for vanilla Emacs. It shall set buffer-auto-revert-by-file-notification-aware when a buffer is setup to dired-mode. Other packages in the wild could do similar settings, think about vc-dir or magit, which use their own machinery. Potentially, any mode which uses (an own implementation of) revert-buffer, would be a candidate for this kind of auto-revert. Thinking about, I'm even not confident that a static value of this indication is sufficient. In dired, it might be set to t when the dired buffer is setup. But what if the dired buffer contains subdirectories? Is it still possible to indicate this by file notifications over default-directory? Don't know, maybe not, and the variable has to be set to nil ... Long story short: we shall start with dired, which sets a buffer-local variable as indication, and we shall edocument this in the Elisp manual. Let's see where we go. Best regards, Michael.