bug#36212: [PATCH] make undo less enthusiastic

bug#36212: [PATCH] make undo less enthusiastic

[Alex Branham]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

This is really minor, but I find it annoying that undo is so
enthusiastic in its messaging. This patch removes the exclamation mark,
which makes undo's messaging more similar to other functions messaging
(e.g. C-g, C-SPC, etc).

Alex


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-simple.el-undo-Make-message-less-enthusiastic.patch --]
[-- Type: text/x-patch, Size: 912 bytes --]

From 5165b92810a29ea409b0dd92179b3599112e1f4e Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 14 Jun 2019 10:00:29 -0500
Subject: [PATCH] * lisp/simple.el (undo): Make message less enthusiastic

---
 lisp/simple.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index 5e9d13f9f8..d9f310b203 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -2530,7 +2530,7 @@ undo
     ;; so, ask the user whether she wants to skip the redo/undo pair.
     (let ((equiv (gethash pending-undo-list undo-equiv-table)))
       (or (eq (selected-window) (minibuffer-window))
-	  (setq message (format "%s%s!"
+	  (setq message (format "%s%s"
                                 (if (or undo-no-redo (not equiv))
                                     "Undo" "Redo")
                                 (if undo-in-region " in region" ""))))
-- 
2.21.0

bug#36212: [PATCH] make undo less enthusiastic

[Mattias Engdegård]

To show my support and appreciation for your attention to detail, please let me propose that the exclamation point be replaced by a full stop.

bug#36212: [PATCH] make undo less enthusiastic

[Noam Postavsky]

severity 36212 wishlist
quit

Alex Branham <alex.branham@gmail.com> writes:

> This is really minor, but I find it annoying that undo is so
> enthusiastic in its messaging. This patch removes the exclamation mark,
> which makes undo's messaging more similar to other functions messaging
> (e.g. C-g, C-SPC, etc).

Mattias Engdegård <mattiase@acm.org> writes:

> To show my support and appreciation for your attention to detail,
> please let me propose that the exclamation point be replaced by a full
> stop.

Alex is right that no punctuation at all is more consistent with
existing messages though.  How about we just go with that for now, and
put off the bike-shedding over punctuation policy for another time.

bug#36212: [PATCH] make undo less enthusiastic

[Alex Branham]

On Fri 21 Jun 2019 at 03:54, Noam Postavsky <npostavs@gmail.com> wrote:

> Alex is right that no punctuation at all is more consistent with
> existing messages though.  How about we just go with that for now, and
> put off the bike-shedding over punctuation policy for another time.

Since no one seemed to hate this, I applied the patch as
cb182ce6f8d2fa6e1509252fecc2b0e504e36d63 on the master branch (Emacs
27.1).

Alex