From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#22792: eshell-mode-map declaration Date: Thu, 27 Jun 2019 10:45:14 -0500 Message-ID: <877e976nhx.fsf@gmail.com> References: <56CDC6D3.1050106@boccaperta.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="221046"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 27.0.50 To: 22792@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 18:13:36 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgX1j-000vPK-GJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 18:13:35 +0200 Original-Received: from localhost ([::1]:52150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgX1i-0007s8-FL for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 12:13:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39039) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgWbF-00078y-6B for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 11:46:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgWb7-0004Ei-HU for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 11:46:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgWb4-0004Bi-KN for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 11:46:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgWb4-0003c2-FJ for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 11:46:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <56CDC6D3.1050106@boccaperta.com> Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2019 15:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22792 X-GNU-PR-Package: emacs Original-Received: via spool by 22792-submit@debbugs.gnu.org id=B22792.156165032411721 (code B ref 22792); Thu, 27 Jun 2019 15:46:02 +0000 Original-Received: (at 22792) by debbugs.gnu.org; 27 Jun 2019 15:45:24 +0000 Original-Received: from localhost ([127.0.0.1]:39329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgWaR-00032i-Qp for submit@debbugs.gnu.org; Thu, 27 Jun 2019 11:45:24 -0400 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:37412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgWaQ-0002wT-7a for 22792@debbugs.gnu.org; Thu, 27 Jun 2019 11:45:22 -0400 Original-Received: by mail-oi1-f171.google.com with SMTP id t76so1928106oih.4 for <22792@debbugs.gnu.org>; Thu, 27 Jun 2019 08:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=8l5N2+StAcnV85VLnxxhNXGiZHxZAlSRKmDc7Xc+0+M=; b=ppD/rokT9yCNMBB+YLHIsGVLKXHYD7SU+7uRywK/ECvPiXnFWHkOiC1tVy8DtcwYd0 kf1e+p139a1VVHtTZlz5gwIVLZtm2WOu6mWgAyozkHPKdr4t3S4DjnqK8KFXt869luUO fI30uQiF9XGLNAvidbSPu2zZbPraaBItCOQj5RizQUekjbZKNvHy8SwQHcmr09iqaCLD 4nHbb088/8hs2kR6O3j/OYOMDiXwDoEeZO/02DxcKgMgR4nZ8HBpihooTcCp9rAubviU fQk0dw/xBWQ+exghSG4+1tYSNCJ89jNeMsAsmRlK/KiwumG7glEjlQ9nk6ReGU1mR+vk q2CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=8l5N2+StAcnV85VLnxxhNXGiZHxZAlSRKmDc7Xc+0+M=; b=DnFzUxjZfD5I8HmBWTQAKcN1qWIdQFTUqakT+Yhsv8oY0braF33qfW7RrXFdGxCCvg s7k+ZwD4JW/yoV+jmtykjuekB3lXCv5u5pfkOQTy5kAI87Z1s37XmAbr0JjiT5Jr1nOt uwNruVLYgn+RQs6GQi/cP5KwzXiEUf9BWxdbtuD8Vt4+oBU7VbmVC3iz0BXM1Zv3olvQ jlvuUx1cYCzoLd7K3hWLfUu1Yr+m95N7R6419A/3ipFlmvDAe+eUAZaeiNHzR8SwFKS2 ZsviFHvtRfqQyqnmqi5NUPfh5uoS7hHQZQBPw6/I6NvkncCKhJnbCwUd1peAzNK/B93+ 6nGQ== X-Gm-Message-State: APjAAAUZJwRv9SYBcmz6Oa6cOWG1hpUs01nLLeGbVyg7TsNsD6OAXQUs Hi6W23pr840IabLqdFg2ljWkmldy X-Google-Smtp-Source: APXvYqzhzjO/uIL9qvRyG5JC/N8EEgCb9TNCdmakFLXULwoJLM4Cbq9qR8+XRNuTpQIx+YU3Mb6aow== X-Received: by 2002:aca:1805:: with SMTP id h5mr2471389oih.93.1561650316095; Thu, 27 Jun 2019 08:45:16 -0700 (PDT) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id p126sm936582oia.10.2019.06.27.08.45.15 for <22792@debbugs.gnu.org> (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 27 Jun 2019 08:45:15 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161603 Archived-At: I can work on this bug. Moving the (re)-definition of eshell-mode-map out of eshell-mode is easy enough. The tricky part is that some of eshell's modules (e.g. em-cmpl) use define-key in eshell-mode-map (or eshell-command-map) too. This results in those keys getting redefined each time eshell is invoked. How do people want to handle that? We could create an em-cmpl minor mode with its own keymap, I suppose. Would that be satisfactory? Thanks, Alex