From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34075: 26.1; calc-time-zone result 2h too low for TZ east of GMT during DST Date: Wed, 10 Jul 2019 00:03:41 +0200 Message-ID: <877e8qrhky.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92126"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34075@debbugs.gnu.org To: David O'Shea Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 10 00:08:47 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkyI3-000Nlc-Mh for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 00:08:47 +0200 Original-Received: from localhost ([::1]:56462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkyHC-00070n-VP for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2019 18:07:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38588) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkyDi-0005jy-7I for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2019 18:04:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkyDc-0001Cj-HO for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2019 18:04:14 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkyDU-00018L-7e for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2019 18:04:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hkyDS-0002Ct-7Y for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2019 18:04:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2019 22:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34075 X-GNU-PR-Package: emacs Original-Received: via spool by 34075-submit@debbugs.gnu.org id=B34075.15627098278463 (code B ref 34075); Tue, 09 Jul 2019 22:04:02 +0000 Original-Received: (at 34075) by debbugs.gnu.org; 9 Jul 2019 22:03:47 +0000 Original-Received: from localhost ([127.0.0.1]:34428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkyDD-0002CR-J9 for submit@debbugs.gnu.org; Tue, 09 Jul 2019 18:03:47 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:54326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkyDB-0002CH-Jn for 34075@debbugs.gnu.org; Tue, 09 Jul 2019 18:03:46 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkyD7-0001LX-C3; Wed, 10 Jul 2019 00:03:43 +0200 In-Reply-To: (David O'Shea's message of "Mon, 14 Jan 2019 11:46:06 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162560 Archived-At: David O'Shea writes: > It seems that when I invoke calc-time-zone, math-get-calendar-tzinfo > is called to get the timezone offset, and it does this: > > (setq math-calendar-tzinfo > (list (* 60 (abs (nth 0 tzinfo))) > (* 60 (nth 1 tzinfo))))))) > > I think the call to abs probably successfully converts the operating > system's view of the timezone offset from negative to positive for > timezones west of Greenwich, but fails to account for timezones east > of Greenwich. > > When I change that code to just invert the sign on the timezone: > > (setq math-calendar-tzinfo > (list (* -60 (nth 0 tzinfo)) > (* 60 (nth 1 tzinfo))))))) Yup, seems to give me correct data to (I get -2, which is correct for Oslo in summer time). I'll push the fix to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no