From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30515: 26.0; `mouse-1' in Profiler report Date: Sun, 14 Jul 2019 18:21:59 +0200 Message-ID: <877e8kzivs.fsf@mouse.gnus.org> References: <80cbb241-0c6c-45ea-98a9-8b145af1fab5@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204561"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30515@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 14 18:28:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmhMC-000qvR-Sa for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jul 2019 18:28:12 +0200 Original-Received: from localhost ([::1]:33236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmhHG-00014e-LD for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jul 2019 12:23:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48758) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmhHD-00014U-QE for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 12:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmhHC-0007fJ-N0 for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 12:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36890) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmhHC-0007fD-Ja for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 12:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmhHC-0005dt-E7 for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 12:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jul 2019 16:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30515 X-GNU-PR-Package: emacs Original-Received: via spool by 30515-submit@debbugs.gnu.org id=B30515.156312132621605 (code B ref 30515); Sun, 14 Jul 2019 16:23:02 +0000 Original-Received: (at 30515) by debbugs.gnu.org; 14 Jul 2019 16:22:06 +0000 Original-Received: from localhost ([127.0.0.1]:45711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmhGI-0005cP-B5 for submit@debbugs.gnu.org; Sun, 14 Jul 2019 12:22:06 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:54624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmhGG-0005cH-HT for 30515@debbugs.gnu.org; Sun, 14 Jul 2019 12:22:05 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmhGB-0003sz-V8; Sun, 14 Jul 2019 18:22:02 +0200 In-Reply-To: <80cbb241-0c6c-45ea-98a9-8b145af1fab5@default> (Drew Adams's message of "Sun, 18 Feb 2018 09:01:55 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163004 Archived-At: Drew Adams writes: > In the output of `profiler-report', `mouse-1' does not respect option > `mouse-1-click-follows-link'. The patch below seems to fix this (and works with mouse-1-click-follows-link both nil or not. But is this really the way to do this stuff these days? It seems so... odd... diff --git a/lisp/profiler.el b/lisp/profiler.el index 775096276d..ee11ff68c5 100644 --- a/lisp/profiler.el +++ b/lisp/profiler.el @@ -473,6 +473,7 @@ profiler-report-make-entry-part (fboundp entry)) (propertize (symbol-name entry) 'face 'link + 'follow-link "\r" 'mouse-face 'highlight 'help-echo "\ mouse-2: jump to definition\n\ @@ -534,9 +535,9 @@ profiler-report-mode-map (define-key map "\r" 'profiler-report-toggle-entry) (define-key map "\t" 'profiler-report-toggle-entry) (define-key map "i" 'profiler-report-toggle-entry) - (define-key map [mouse-1] 'profiler-report-toggle-entry) (define-key map "f" 'profiler-report-find-entry) (define-key map "j" 'profiler-report-find-entry) + (define-key map [follow-link] 'mouse-face) (define-key map [mouse-2] 'profiler-report-find-entry) (define-key map "d" 'profiler-report-describe-entry) (define-key map "C" 'profiler-report-render-calltree) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no