From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 30515@debbugs.gnu.org
Subject: bug#30515: 26.0; `mouse-1' in Profiler report
Date: Sun, 14 Jul 2019 18:21:59 +0200 [thread overview]
Message-ID: <877e8kzivs.fsf@mouse.gnus.org> (raw)
In-Reply-To: <80cbb241-0c6c-45ea-98a9-8b145af1fab5@default> (Drew Adams's message of "Sun, 18 Feb 2018 09:01:55 -0800 (PST)")
Drew Adams <drew.adams@oracle.com> writes:
> In the output of `profiler-report', `mouse-1' does not respect option
> `mouse-1-click-follows-link'.
The patch below seems to fix this (and works with
mouse-1-click-follows-link both nil or not.
But is this really the way to do this stuff these days? It seems so...
odd...
diff --git a/lisp/profiler.el b/lisp/profiler.el
index 775096276d..ee11ff68c5 100644
--- a/lisp/profiler.el
+++ b/lisp/profiler.el
@@ -473,6 +473,7 @@ profiler-report-make-entry-part
(fboundp entry))
(propertize (symbol-name entry)
'face 'link
+ 'follow-link "\r"
'mouse-face 'highlight
'help-echo "\
mouse-2: jump to definition\n\
@@ -534,9 +535,9 @@ profiler-report-mode-map
(define-key map "\r" 'profiler-report-toggle-entry)
(define-key map "\t" 'profiler-report-toggle-entry)
(define-key map "i" 'profiler-report-toggle-entry)
- (define-key map [mouse-1] 'profiler-report-toggle-entry)
(define-key map "f" 'profiler-report-find-entry)
(define-key map "j" 'profiler-report-find-entry)
+ (define-key map [follow-link] 'mouse-face)
(define-key map [mouse-2] 'profiler-report-find-entry)
(define-key map "d" 'profiler-report-describe-entry)
(define-key map "C" 'profiler-report-render-calltree)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next parent reply other threads:[~2019-07-14 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <80cbb241-0c6c-45ea-98a9-8b145af1fab5@default>
2019-07-14 16:21 ` Lars Ingebrigtsen [this message]
2019-07-25 20:01 ` bug#30515: 26.0; `mouse-1' in Profiler report Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e8kzivs.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=30515@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.