From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23799: 25.0.90; Replying "no" to send bug report means you cannot later send it Date: Sun, 28 Jul 2019 13:48:35 +0200 Message-ID: <877e82crcc.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="105370"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 23799@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 13:49:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrhfp-000RGC-8X for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 13:49:09 +0200 Original-Received: from localhost ([::1]:44610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrhfo-00005s-BC for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 07:49:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43057) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrhfj-00005k-Kh for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 07:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrhfi-0004pN-9f for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 07:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37022) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrhfi-0004pH-6c for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 07:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrhfi-0005wA-3M for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 07:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 11:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23799 X-GNU-PR-Package: emacs Original-Received: via spool by 23799-submit@debbugs.gnu.org id=B23799.156431452222795 (code B ref 23799); Sun, 28 Jul 2019 11:49:02 +0000 Original-Received: (at 23799) by debbugs.gnu.org; 28 Jul 2019 11:48:42 +0000 Original-Received: from localhost ([127.0.0.1]:45842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrhfO-0005vb-AJ for submit@debbugs.gnu.org; Sun, 28 Jul 2019 07:48:42 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:54544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrhfM-0005vR-Eo for 23799@debbugs.gnu.org; Sun, 28 Jul 2019 07:48:41 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrhfI-0003dS-0e; Sun, 28 Jul 2019 13:48:38 +0200 In-Reply-To: (Drew Adams's message of "Sat, 18 Jun 2016 17:12:47 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163944 Archived-At: Drew Adams writes: > Hit C-c C-c to send a bug report, then reply "no", perhaps because you > want to change something before submitting the report. > > Now try C-c C-c again. > > You get an error/message saying: > > message-send: No methods specified to send by It looks like this puzzling behaviour is because of this puzzling code: (goto-char (point-min)) (if (search-forward "To: ") (delete-region (point) (line-end-position))) (if report-emacs-bug-send-hook (kill-local-variable report-emacs-bug-send-hook)) Which was introduced by the patch below, apparently, which doesn't say anything about why it's removing the To: header or why it's removing the hook (you don't get any queries the second time around, either). Hm... Oh! I didn't even notice that when you type "no", it switches out the help buffer text: (with-output-to-temp-buffer "*Bug Help*" (princ (substitute-command-keys (format "\ You invoked the command M-x report-emacs-bug, but you decided not to mail the bug report to the Emacs maintainers. If you want to mail it to someone else instead, please insert the proper e-mail address after \"To: \", and send the mail again%s." So the intention here is that if you say "no", then you're never ever going to send the message to the Emacs maintainers. I think that's a pretty unexpected thing to infer from just the "no". I've now removed that code that removes the To and the hook, which then allows the user to change their minds. commit fe1d8b33cbeadad8cd9c186553ecf87b8bbf314d Author: Kenichi Handa Date: Tue Jul 15 08:23:58 1997 +0000 (report-emacs-bug-run-tersely): New variable (report-emacs-bug): Insert warnings for novice usres in *mail* buffer. Set enable-multibyte-characters to nil. (report-emacs-bug-hook): Check non-English letters. Confirm about sending a report to FSF. diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -150,1 +187,11 @@ - (error "No text entered in bug report")))) + (if (or report-emacs-bug-run-tersely + (yes-or-no-p + "Do you surely send this mail to Free Software Foundation? ")) + ;; Just send the current mail. + nil + (goto-char (point-min)) + (if (search-forward "To: ") + (let ((pos (point))) + (end-of-line) + (delete-region pos (point)))) + (kill-local-variable 'mail-send-hook) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no