From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Date: Thu, 01 Aug 2019 06:54:08 +0200 Message-ID: <877e7xjxjj.fsf@gnu.org> References: <87ef26ac17.fsf@gnu.org> <87a7cuvyg3.fsf@mouse.gnus.org> <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> <87v9vinefd.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="68420"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 01 06:54:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ht36W-000Hfv-KU for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 06:54:16 +0200 Original-Received: from localhost ([::1]:45874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht36V-0004rh-NQ for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 00:54:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42039) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht36R-0004rb-P2 for emacs-devel@gnu.org; Thu, 01 Aug 2019 00:54:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ht36R-0003eT-Js; Thu, 01 Aug 2019 00:54:11 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:52389) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1ht36R-0007eO-De; Thu, 01 Aug 2019 00:54:11 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id B204F21F82; Thu, 1 Aug 2019 00:54:10 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 01 Aug 2019 00:54:10 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleeigdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepvfgrshhsihhl ohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucfkphepudefgedrudduledrvd egrdduleehnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgr uhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhh eppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhmnecuvehluhhsthgvrhfuihiivgep td X-ME-Proxy: Original-Received: from jiffyarch (j289989.servers.jiffybox.net [134.119.24.195]) by mail.messagingengine.com (Postfix) with ESMTPA id D91CC80059; Thu, 1 Aug 2019 00:54:09 -0400 (EDT) In-Reply-To: <87v9vinefd.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Wed, 31 Jul 2019 22:21:10 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239084 Archived-At: Lars Ingebrigtsen writes: Hi Lars, >> It's not just moving point. replace-region-contents also keeps marks, >> text properties and fontification intact. So we should definitely be >> using it here. > > Ah, I see. I only gave that function a cursory look-over when fixing > this bug and I didn't quite understand what it was doing here, since I > couldn't recall any other pretty-printer doing anything similar. No worries! You probably didn't see it more often because it's quite new. But pretty-printing is definitely a very good use-case for it. > Sorry for the confusion here; I've now restored the > replace-region-contents logic. Or at least I think so; it works with > the test cases in this bug report, at least. Yes, it works again. Thanks! It can still be a bit improved in understandability and efficiency. 1. The function passed to replace-region-contents runs on the narrowed buffer anyway, so no need to narrow it yourself. 2. It would be better to create a temporary buffer, json-read repeatedly from the original buffer, json-encode/insert to the temp one, and then return the temp buffer. The reason for point 2 is that if the function passed to replace-region-contents returns a string, it'll put that in a temporary buffer anyhow so that it can use replace-buffer-contents to perform the actual replacement (replace-region-contents is just a wrapper around that). And we might want to cater for the situation where the region starts or ends inside a json object by copying the buffer substring from (point) to end to the temp buffer in case json-read fails. I think right now, we'd lose such half json objects and everything which follows them. Bye, Tassilo