From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b75fb81 1/4: Extend button.el to take callback data Date: Thu, 01 Aug 2019 18:12:51 +0200 Message-ID: <877e7wlv98.fsf@mouse.gnus.org> References: <20190730132507.32385.70681@vcs0.savannah.gnu.org> <20190730132509.77D2820C0A@vcs0.savannah.gnu.org> <87lfwd2ihn.fsf@tcd.ie> <87pnlpm5x9.fsf@mouse.gnus.org> <87ef24vrpz.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="25369"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 01 18:13:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htDha-0006St-Vg for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 18:13:15 +0200 Original-Received: from localhost ([::1]:57348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htDha-00024a-0X for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 12:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50774) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htDhN-00024Q-5d for emacs-devel@gnu.org; Thu, 01 Aug 2019 12:13:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htDhL-0007pB-9x for emacs-devel@gnu.org; Thu, 01 Aug 2019 12:13:01 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36502) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1htDhJ-0007o8-MH for emacs-devel@gnu.org; Thu, 01 Aug 2019 12:12:59 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htDhD-0001qK-W1; Thu, 01 Aug 2019 18:12:54 +0200 In-Reply-To: <87ef24vrpz.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 01 Aug 2019 18:19:04 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239111 Archived-At: "Basil L. Contovounesios" writes: > I don't understand what you mean by "recreate the data" or "looking at > the extent of the buttons". > > If an action function depends on some data associated with its button, > then it is up to the creator or modifier of the button to tag it with > that data. The action function then need only do a property lookup via > button-get. Here's a typical usage: (make-text-button start (point) 'face 'rcirc-url 'follow-link t 'rcirc-url url 'action (lambda (button) (browse-url (button-get button 'rcirc-url)))) with the "button knows the data" change, it's: (make-text-button start (point) 'face 'rcirc-url 'follow-link t 'burron-data url 'action #'browse-url) That looks like an interface improvement to me. > Alternatively, action functions can also be closures. They can be, in lexical packages. > I don't mind the name 'button-data', and I wasn't worried about naming > collisions. > > What I'm worried about is the existence of buttons in the wild, whose > existing action functions will break if said buttons happen to be given > a button-data property. This seems unnecessarily brittle and > backward-incompatible, in exchange for what seems like an insufficiently > useful convenience. Unless I'm missing something, that is. But you said you're not worried about naming collisions? How would these buttons then "happen to be given" that property? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no