From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36871: 26.1; I-search-toggle-csse-fold Date: Sun, 04 Aug 2019 16:53:57 -0400 Message-ID: <877e7sslcq.fsf@gmail.com> References: <001201d54775$5ca376a0$15ea63e0$@mail.ru> <83lfwei9ft.fsf@gnu.org> <85o91a47l2.fsf@gmail.com> <83a7cui776.fsf@gnu.org> <004b01d547b3$0cdb14a0$26913de0$@mail.ru> <87k1bxu4vj.fsf@gmail.com> <87ftmivt4a.fsf@mail.linkov.net> <8736igslyx.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122592"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: a_subscriber , 36871@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 22:55:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huNX3-000Vlo-R8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 22:55:09 +0200 Original-Received: from localhost ([::1]:49520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huNX2-00073k-7q for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 16:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38101) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huNWx-00073d-1L for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 16:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huNWw-0008EO-3S for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 16:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53721) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huNWv-0008E7-Tn for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 16:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huNWv-0007pY-PL for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 16:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 20:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 36871-submit@debbugs.gnu.org id=B36871.156495204730034 (code B ref 36871); Sun, 04 Aug 2019 20:55:01 +0000 Original-Received: (at 36871) by debbugs.gnu.org; 4 Aug 2019 20:54:07 +0000 Original-Received: from localhost ([127.0.0.1]:34309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huNW3-0007oL-AS for submit@debbugs.gnu.org; Sun, 04 Aug 2019 16:54:07 -0400 Original-Received: from mail-io1-f54.google.com ([209.85.166.54]:33701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huNW0-0007nq-KC for 36871@debbugs.gnu.org; Sun, 04 Aug 2019 16:54:05 -0400 Original-Received: by mail-io1-f54.google.com with SMTP id z3so22068434iog.0 for <36871@debbugs.gnu.org>; Sun, 04 Aug 2019 13:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cBRSTX93wP9nLC3mIa7hLGPmQNROG6AKC4aLW6krMPI=; b=ImiZazLVz+cY4sCtfCBkm+wBlDDlfFt3F01xbTBkh/rv3SkFcul8x8SiCJnWPyDeQq d8PhvImjht1IL3u8fljEEEq9tOOyvnksSXoB4QfL5i09xMcUJLByRezglRDy0wbDvTyi 5bepJVSdxxQ6T9Q4JkyBK+DHGOMkVo8wkiY9/JqZ6aFewPcdXzTxm9Gc7a9FAL4oXP6v ahqfR6LV+ClrTEF/5rJKcirOt0QyI6zbzvWDECogx3KKGYW4JeXCp8UDCViktXTYnQDk AG56GDbvvNKaelMINJC7mz993qMXxNer7CXeNJX7JVUiUeUo6luP3VQsmcK7t4foXaO+ VEOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cBRSTX93wP9nLC3mIa7hLGPmQNROG6AKC4aLW6krMPI=; b=UD5joYo347BB8LrBu4YnCY7daJG4nN6PuSP2DYlR89XiySCY8BJ/ovYy8dHfR6Uww4 E7/OiEzRsyyYwWxHHFCwFHKDIEoGIieX13TvMqWXUUcGufhgI8qii958i1auJAD0dDAL 08h7wOFIEASb660fpLEx/gaMWB6mqyZsCSB5c/WBVrGMj1rlYaAuufWZk/gtnzuxGIIz GK1F8tLEPdwmJ9vK+cRSphmYSwxwn8Y2bXs/2n8ufsvrajgB92oEXCb5g9JvF4OnjGY0 LHnASZe+aMub1xLf4b6tJxSyNOScq6ZHRxkzWtRGNNKuMh+yqd/GWiLg7QlGGLCfoSrp IASw== X-Gm-Message-State: APjAAAWryMx6ktPm72p/qiCoa/9MYnV4H1uWupkmWRzQ1CP+IoZh59qP 6oJ+Lqesyzsy6KMk6QXxYllKBvQ8 X-Google-Smtp-Source: APXvYqydgaK/ohscm6oszunJK+xPB6M69MwefrJYUZLZhkq2++bm65g+8bqZ6ghYupnGpJtW0cWNhA== X-Received: by 2002:a02:c6b8:: with SMTP id o24mr11490921jan.80.1564952038814; Sun, 04 Aug 2019 13:53:58 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id s14sm6523493ioc.32.2019.08.04.13.53.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Aug 2019 13:53:58 -0700 (PDT) In-Reply-To: <8736igslyx.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 04 Aug 2019 23:46:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164598 Archived-At: Juri Linkov writes: >> Shouldn't toggling commands activate isearch-mode? > > I meant the same guarding like in isearch-yank-kill: > @@ -1971,6 +1971,7 @@ isearch-define-mode-toggle > ,(format "Toggle %s searching on or off.%s" mode > (if docstring (concat "\n" docstring) "")) > (interactive) > + (unless isearch-mode (isearch-mode t)) +1 from me, I like this better than throwing an error.