bug#9670: Bad interaction between defining-kbd-macro and desktop

bug#9670: Bad interaction between defining-kbd-macro and desktop

[Antoine Levitt]

C-x (
M-x desktop-save

will result in the desktop file being unusable unless defining-kbd-macro
is removed manually. Adding defining-kbd-macro to
desktop-minor-mode-table does not change the problem. I believe this is
because defining-kbd-macro does not follow the usual convention for
minor modes, and therefore defeats this code in desktop-create-buffer:

(let ((handler (cdr (assq minor-mode desktop-minor-mode-handlers))))
  (if handler
      (funcall handler desktop-buffer-locals)
    (when (functionp minor-mode)
      (funcall minor-mode 1))))

bug#9670: Bad interaction between defining-kbd-macro and desktop

[Lars Ingebrigtsen]

Antoine Levitt <antoine.levitt@gmail.com> writes:

> C-x (
> M-x desktop-save
>
> will result in the desktop file being unusable unless defining-kbd-macro
> is removed manually.

(I'm going through old bug reports that have unfortunately gotten no
attention yet.)

I tried reproducing this in Emacs 27, but was unable to.

If I follow your recipe (from "emacs -Q") my .emacs.desktop file does
not contain anything referring to "defining-kbd-macro".

Do you still see this in a modern Emacs, or has it been fixed in the
intervening years?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#9670: Bad interaction between defining-kbd-macro and desktop

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Antoine Levitt <antoine.levitt@gmail.com> writes:
>
>> C-x (
>> M-x desktop-save
>>
>> will result in the desktop file being unusable unless defining-kbd-macro
>> is removed manually.
>
> (I'm going through old bug reports that have unfortunately gotten no
> attention yet.)
>
> I tried reproducing this in Emacs 27, but was unable to.
>
> If I follow your recipe (from "emacs -Q") my .emacs.desktop file does
> not contain anything referring to "defining-kbd-macro".
>
> Do you still see this in a modern Emacs, or has it been fixed in the
> intervening years?

More information was requested some weeks back, but no response was
given, so I'm closing this bug report.  If you're still seeing this
problem, please reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#9670: acknowledged by developer (control message for bug #9670)

[Antoine Levitt]

Hm, for some reason I didn't get a notification for the comment you sent
in august. Just tried it and it worked without problem, guess it was
fixed sometimes during the past 8 years! Thanks for tackling this.