From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#36940: tests slowness and failure after recent Tramp changes Date: Mon, 26 Aug 2019 13:47:02 +0200 Message-ID: <877e70w3m1.fsf@gmx.de> References: <57e233fe-19e9-6eac-7fd5-7e181879d4df@cs.ucla.edu> <8736ibkbne.fsf@gmx.de> <87mughfj96.fsf@gmx.de> <470b50ab-6658-e3cb-cd59-916c398c442f@cs.ucla.edu> <87h86of1tm.fsf@gmx.de> <87v9v0avhm.fsf@gmx.de> <8736hryoi1.fsf@gmx.de> <87lfvhy4qp.fsf@gmx.de> <83pnkth8ty.fsf@gnu.org> <83mufxh820.fsf@gnu.org> <87ftlpxz89.fsf@gmx.de> <83imqlh3st.fsf@gnu.org> <877e71xyax.fsf@gmx.de> <83ftlph2wx.fsf@gnu.org> <87blwcwabb.fsf@gmx.de> <83lfvgfdru.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="155674"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: eggert@cs.ucla.edu, stefan@marxist.se, 36940@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 26 13:48:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2DUA-000eKD-S5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 13:48:35 +0200 Original-Received: from localhost ([::1]:51880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2DU9-0005lG-7C for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 07:48:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48640) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2DTf-0005l8-3X for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 07:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2DTd-0006Kt-W7 for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 07:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2DTd-0006Kn-Ss for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 07:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2DTd-0005Ht-Mj for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 07:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2019 11:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36940 X-GNU-PR-Package: emacs Original-Received: via spool by 36940-submit@debbugs.gnu.org id=B36940.156682005020278 (code B ref 36940); Mon, 26 Aug 2019 11:48:01 +0000 Original-Received: (at 36940) by debbugs.gnu.org; 26 Aug 2019 11:47:30 +0000 Original-Received: from localhost ([127.0.0.1]:45708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2DT7-0005H0-I5 for submit@debbugs.gnu.org; Mon, 26 Aug 2019 07:47:29 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:44807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2DT5-0005GZ-EB for 36940@debbugs.gnu.org; Mon, 26 Aug 2019 07:47:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566820027; bh=Pr66EJh7z2ivDjMj6kGcDlIjXKA+CTXO+ik+QDA31u4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=JMBfkeVEX8Kt1RxYBKXhfAVwDfUeRnIqchF0g31x1Ds8ClexSA1QHHY1B5+48kVle JVqk5EVsk18oqzsALt2oNyBe4vilmNJX374k+c62XRvGNpdZ2u/d3nAxWTLnARNkOU TVHPSWMosrWPcti36HSgzMb6xAjC7aNHc2Z9oXvc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([178.20.95.58]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M5cMq-1iQEYV2pCq-00xZu6; Mon, 26 Aug 2019 13:47:07 +0200 In-Reply-To: <83lfvgfdru.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 26 Aug 2019 12:59:33 +0300") X-Provags-ID: V03:K1:ilLuirfl6CTFH0TsblEQIvIoa0VObnVbTdYoOppVwnWZ6RAlmOl yd2R9YNaLkGsWSyUQQbMvTxS+xCeIk8/u0a2Etjd4giZKFtMWKiZj9xSPQPKrrxfRlQE9p7 I74bFW+dsN7n2GNpwWmHA7wsQzVgpe1NPSGunNNVc2A4lNuGjFrAqZyIwXJNxVAF/7+Mt05 g6X3c7WdTEp+mOD+aEoQw== X-UI-Out-Filterresults: notjunk:1;V03:K0:EwhSN18pBj0=:kBMaXdlam+QKkpe43vJYCD 0SGptkWqnmIjTKGgj6ee9/PYyvcaNxQx//IggchatERUQzAxG3R831yAgOgBdA1a3NQMN+aok PQTi8xjwYz6wStnvRk5Qp0yGZ4otgg37dF7S3EDxGj6tuczHJdDPp/as7mrZkSItCyKALl4dI sKLCyGpR7Gs1mcLaZa6sJH2hqcGtjWuMrz4dUUpBKpCTGC50BbuYflnGujd6V1bt1IpwDNm/k 4nLmTsjEKoTa6ZWDAi0CWxRja6X64FuK1ezWVDvsU0Qow96CJRehc4nwxEvFAzdKVd8Fth+96 YKUO1bK3CUmHkhCzc2OvGI33kBxzuiwVLHM3RZuHCrCKCjj9FYZST8k2f9I4pLFE2tQcDnR+p OdgKEf10fyPQrTw49m4EnBg+7cPp94Zsx26uABL1r3i8e1eCuq7QnANO2qK3bpIXn66beMGVH yun+WLxOkMGeIwx79GP5KZLqk0h+Eud8jMAdC9HV+C6dbqDqDkOTU/o7vPxRpBkwUaxKZyz+l PjKPNkqM7Ud+2IQ5XiMt6/xne32muHBAryCMe+oYrdtBYmNWGLUhTazrjOgAO6Undh/W6mSip SnT+ouK6Yg7Le3pdKuJ8Mfj2JC39k736N5kf4KeEjzT1JikOzWq/at/LSONgD/jsf56ouyl2V mvq7i15pEEdFeXwYxlppUDq4OPTL80ob553vxwaK1Cv8XwWv+vfFw9fafMofuLIX4sVM7te04 z7aEJuG1h2QHOlDChpnS0STcn4Nc25is6N37N827qsOTCaPrhFfABSO8tl6liIrphdTtMGUB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165898 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: Hi Eli, >> The error happens while searching in a process buffer, which is set pro= perly: >> >> 14:40:39.573073 tramp-open-connection-setup-interactive-shell (5) # >> Setting coding system to `utf-8-hfs' and `utf-8-hfs-mac' >> >> But the search string needs to be normalized as proposed by you. Will d= o. > > Sorry for bothering you, but now I am confused. If the process > buffer's contents is decoded with utf-8-hfs, then decoding should have > composed the characters back, I believe. So the text to be searched > in the buffer should use the precomposed character U+03AF GREEK SMALL > LETTER IOTA WITH TONOS. Is that so? And if so, is the problem with > the regexp you pass to re-search-forward? Then where did that regexp > come from -- maybe the problem happens while you produce that regexp? Now I start to understand what happens. In tramp--test-check-files, there is a loop over the test strings, which are used for different test purposes. At the very end, an environment variable is set as (setenv envvar elt) When the failing regexp search is applied, the original string is not taken, but the set environment variable (should (re-search-forward (format "^%s=3D%s$" (regexp-quote envvar) (regexp-quote (getenv envvar)))))))))) Likely, (getenv envvar) returns the encoded string, which fails. Using the original string shall work. > Feel free to ignore my questions if they are just a distraction, due > to my unfamiliarity with the text internals. No, you're very helpful as usual! Thanks! Stefan, does the following patch solves the problem for you? --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el index 557536a0eb..6ce1afa4a7 100644 =2D-- a/test/lisp/net/tramp-tests.el +++ b/test/lisp/net/tramp-tests.el @@ -5288,7 +5288,7 @@ tramp--test-check-files (format "^%s=3D%s$" (regexp-quote envvar) - (regexp-quote (getenv envvar)))))))))) + (regexp-quote elt))))))))) ;; Cleanup. (ignore-errors (delete-directory tmp-name1 'recursive)) --=-=-= Content-Type: text/plain Best regards, Michael. --=-=-=--