From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file Date: Tue, 27 Aug 2019 11:05:33 +0200 Message-ID: <877e6z2d2a.fsf@gnus.org> References: <87a7ic9due.fsf@gnu.org> <87muhnrwvs.fsf@mouse.gnus.org> <875zmk5r5u.fsf@gnus.org> <83sgpofjc9.fsf@gnu.org> <87k1b04a3x.fsf@gnus.org> <83pnksfel0.fsf@gnu.org> <87v9uj2i7l.fsf@gnus.org> <83mufvdomu.fsf@gnu.org> <87ftln2f0f.fsf@gnus.org> <83imqjdmqb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="85305"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34720@debbugs.gnu.org, dunni@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 27 11:06:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2XQa-000LwY-A0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2019 11:06:12 +0200 Original-Received: from localhost ([::1]:48514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2XQZ-0004ci-5Z for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2019 05:06:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42935) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2XQR-0004bx-6J for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 05:06:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2XQQ-0003pe-08 for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 05:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2XQP-0003pY-TI for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 05:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2XQP-0000SP-MJ for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 05:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2019 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34720-submit@debbugs.gnu.org id=B34720.15668967411731 (code B ref 34720); Tue, 27 Aug 2019 09:06:01 +0000 Original-Received: (at 34720) by debbugs.gnu.org; 27 Aug 2019 09:05:41 +0000 Original-Received: from localhost ([127.0.0.1]:47671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2XQ5-0000Rr-AF for submit@debbugs.gnu.org; Tue, 27 Aug 2019 05:05:41 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:39256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2XQ2-0000Rg-DS for 34720@debbugs.gnu.org; Tue, 27 Aug 2019 05:05:38 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2XPy-0007L9-8Z; Tue, 27 Aug 2019 11:05:36 +0200 In-Reply-To: <83imqjdmqb.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 27 Aug 2019 11:41:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165949 Archived-At: Eli Zaretskii writes: > Must be sheer luck. Or maybe I'm missing something, but you will have > to show me the code that moves this test marker to convince me. (I > don't have the necessary software installed to repeat the recipe myself.) (progn (find-file "/tmp/foo.txt") (kill-buffer (current-buffer)) (when (file-exists-p "/tmp/foo.txt") (delete-file "/tmp/foo.txt")) (find-file "/tmp/foo.txt") (insert "Test line.") (setq test-marker1 (make-marker)) (move-marker test-marker1 4) (setq test-marker2 (make-marker)) (move-marker test-marker2 5) (save-buffer t) (shell-command "echo new >> /tmp/foo.txt") (revert-buffer nil t) (list test-marker1 test-marker2)) => (# #) So the markers seem to be restored on `revert-buffer'? The reason this doesn't happen in the epa case seems to be a bug in Finsert_file_contents: When there's an external handler, it skips directly to handled: and neglects to do the same_at_start computation, which leaves that at point-min and restore_window_points ignores all markers that have values that are larger than same_at_start. If I'm reading the code right. If the new text doesn't match the old text, the markers are not restored: (progn (find-file "/tmp/foo.txt") (kill-buffer (current-buffer)) (when (file-exists-p "/tmp/foo.txt") (delete-file "/tmp/foo.txt")) (find-file "/tmp/foo.txt") (insert "Test line.") (setq test-marker1 (make-marker)) (move-marker test-marker1 4) (setq test-marker2 (make-marker)) (move-marker test-marker2 5) (save-buffer t) (shell-command "echo Here is a new text > /tmp/foo.txt") (revert-buffer nil t) (list test-marker1 test-marker2)) (# #) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no