From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#37489: 27.0.50; Make `debbugs-gnu-search' work with `repeat-complex-command' Date: Tue, 24 Sep 2019 08:51:58 +0200 Message-ID: <877e5y6vap.fsf@gmx.de> References: <87v9tjo7en.fsf@web.de> <87muevkutt.fsf@gmx.de> <87ef064cv1.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="8424"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37489-done@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 24 08:53:57 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCehx-000226-Hq for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 08:53:57 +0200 Original-Received: from localhost ([::1]:41490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCehv-00082F-Nw for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 02:53:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34888) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCeh5-00081y-Vd for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 02:53:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCeh4-0001MQ-NI for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 02:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iCeh4-0001MD-Jj for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 02:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iCeh4-0001v9-HL for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 02:53:02 -0400 Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2019 06:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 37489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 37489@debbugs.gnu.org, michael.albinus@gmx.de, michael_heerdegen@web.de Original-Received: via spool by 37489-done@debbugs.gnu.org id=D37489.15693079317319 (code D ref 37489); Tue, 24 Sep 2019 06:53:02 +0000 Original-Received: (at 37489-done) by debbugs.gnu.org; 24 Sep 2019 06:52:11 +0000 Original-Received: from localhost ([127.0.0.1]:37488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCegF-0001ty-4t for submit@debbugs.gnu.org; Tue, 24 Sep 2019 02:52:11 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:46925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCegD-0001tl-12 for 37489-done@debbugs.gnu.org; Tue, 24 Sep 2019 02:52:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1569307921; bh=+mzelRfjlO4L4U3HwHcJLQ5WM06VyDQK12xr/qbO67g=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ZqlAdZ7z4V0zaMgfhqnfYTcsMYfwLvdVXCIY8nq6rMBkomReEWCLofeLneC8ZR0FD F7UFBuOo1b9bhYp59ybDHZyPgEgOARBZ0jIC6KARgfuBdebcogjdt/MajQubnadscW ONCGKNTHWR+zSd/I9zlChhFez9U+HJoQRyMbgyiY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.50.177]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4s0t-1iE1ix348V-001w3o; Tue, 24 Sep 2019 08:52:00 +0200 In-Reply-To: <87ef064cv1.fsf@web.de> (Michael Heerdegen's message of "Tue, 24 Sep 2019 05:00:50 +0200") X-Provags-ID: V03:K1:K085Iy4u5mYZLGmDZwtCQs6MptisNlOYe1V+IBYSUH2Iid+5NVM QjLkZIZxVLz+8NlN1XbFF3IwNXi7C5t6w959D7bs+rKu2M3GXZMOkLse9HcVgz35NNMXY7R IPohWmHUHkJmJOBq1NrD35eK8gpaAqe/UCAAISW3lV8UTU2SeT6UmIT+V0h4chYf34zdUSM TTucPHcbtXxOQ7sBrTKdQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:GDcDpuOFcNg=:6Kv7uuHkmHjfmWU/mZ5pKj puzab/b3MPxrIKPPBZc+S1I8O35qSrARFzxmVGr3jP7ni8XnTdR/X3GnvPTy+iBzhvbWntBM6 c+PAN9XwKm8BWiqAVcOhggZhj9Ausg0DzX4FG59/sbbd4ywnrDOT0VXQJDNZAdCE/TaxGJklI zyLUudkQLbEHXsYNdaPEZdB0rct0QsJtwtdIme6bJMSqNDhdyLVFwOzSKIdfiXzcfiae7fy7o q11f81ZoRNxcySsVQI4mnI6D7L3ly14pwqD97BzcRV1CysO12st8rsd3ZdEl526wrQvhThNm8 a5h5Ehq5uBm4R3LBpstE4GXhuTPhaDFuiNxoGZYMq3ZZeS23Y1XAU1etw9m+hRkpf3x9ygsVF yvUxXKgfZ7iKWEoEylCy9LK0sUg7xgQ64DlsBRIM9+xDroMHM9mCCrHHnz0AU4ZPViP/pVLyb NMzkwQ3VM2CVgsKFkbJirPcivcDNWy/D3kK8OuNeNfX1NtuljRROU1vlgF/L9+GwrkEE7hChh bLzEXxnalcaQYEAXV4zu9PNj0+oicNxni6VHrqQJxCxGx9lj/It3ecNn3adPbJw/hlinlhM23 EACf3PqSMN9Tk/QirPNAu/aHZ0JpPR2KL5lM6SWQXcsj9WKQHyMYROAhin9PiXqDeJPRozbM4 QzYt7BdYiRZvD7HybR9eUADe4CLBuuNsaZrxlqyA1mv9XCyyMdCJo/y6ylnJ7KGqPzu668Tul VOW0c61LGi2TDHFDKRdCINvT9XDm71NO360BJAbVYdmWr1+nxKSlSwASPDVFeEuv711TdaCM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167073 Archived-At: Michael Heerdegen writes: Hi Michael, >> The appended patch shall do the job, you might test. > > Seems to work fine, yes, thanks. Thanks for testing. There was still an error in the patch; it didn't distinguish between queries and filters. I have fixed this. >> However, I fear we will open a Pandora's box. We must set both >> debbugs-gnu-current-query and debbugs-gnu-current-filter, it depends >> on whether PHRASE is a string, or not. And even the allowed arguments >> in both cases are different. So it is very easy to make it wrong when >> editing the argument list. Even *I* would need to consult the >> implementation, in order to know what's allowed, and what's >> not. > > I don't find it this problematic. It's ok when not all combinations of > arguments are allowed. But instead of consulting the implementation, it > would of course be better to describe limitations in the docstring. If > it gets too complicated, maybe the list of arguments could be changed to > reflect the implementation even more. It's even more complex. There is the difference whether an argument is appropriate or not, depending on QUERY being a string or nil. But there is also the difference whether an argument is sent to the server, or whether the argument's discrimination is done client-side. The latter is much less performant. > Anyway, the patch is all that I wanted. If the command barks the last > resort is to go through the queries again, which I have to do now > anyway. > >> I would add some further sanity checks for QUERY, before callings >> debbugs-gnu. > > That might be appropriate, but adding some details to the docstring in > addition along the way might not be wrong, too. You don't even need to > explain each argument in detail (maybe you could even point to other > functions' docstring for that?), just enough to let me know what would > not work. FWIW, I never called the command with an empty phrase, since > I didn't know that this is allowed and even then I would rather expect > that the server would blacklist me :-) See the manual, it tells you :-) `debugs-gnu search' is designed to handle all of this interactively. Now, that we have arguments, and this command can be called like a function, I've added a reference to the docstring, pointing to the manual. Plus the promised sanity checks. I've pushed the changes to GNU ELPA. I've also released debbugs 0.20, because the solution for bug#36903, which was blocking the release, is expected to be applied in gnus. > Regards, > > Michael. Best regards, Michael.