From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#26923: 25.2; `setq-local': allow multiple assignments or add optional buffer arg Date: Wed, 09 Oct 2019 10:15:49 +0200 Message-ID: <877e5epc5m.fsf@gnus.org> References: <986f9da4-6f75-48fc-a41c-f6a44343bfa2@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="55283"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 26923@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 19:25:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIFiK-000E97-JX for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 19:25:28 +0200 Original-Received: from localhost ([::1]:53016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFiI-0007K9-KM for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 13:25:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44888) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI79c-0005n6-5H for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 04:17:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI79a-0001ZZ-Qj for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 04:17:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI79a-0001ZU-NL for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 04:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iI79a-0006SD-F0 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 04:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 08:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26923 X-GNU-PR-Package: emacs Original-Received: via spool by 26923-submit@debbugs.gnu.org id=B26923.157060896324728 (code B ref 26923); Wed, 09 Oct 2019 08:17:02 +0000 Original-Received: (at 26923) by debbugs.gnu.org; 9 Oct 2019 08:16:03 +0000 Original-Received: from localhost ([127.0.0.1]:52073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI78c-0006Ql-Tl for submit@debbugs.gnu.org; Wed, 09 Oct 2019 04:16:03 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI78a-0006QE-NS for 26923@debbugs.gnu.org; Wed, 09 Oct 2019 04:16:01 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI78P-0004r4-Vp; Wed, 09 Oct 2019 10:15:59 +0200 In-Reply-To: <986f9da4-6f75-48fc-a41c-f6a44343bfa2@default> (Drew Adams's message of "Sun, 14 May 2017 07:15:16 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168729 Archived-At: Drew Adams writes: > 1. I believe this has been discussed before, and presumably the result > (decision or lack of one) has been not to make the change, but I'd > still suggest that `setq-local', like `setq', should allow multiple > assignment pairs. This was implemented by Jordon Biondo but never applied. Biondo has copyright assignment papers on file, but apparently the final movement here was this email from Eli: > > From: Jordon Biondo > > Date: Wed, 8 Feb 2017 10:59:19 -0500 > > Cc: John Wiegley , Emacs development discussions > > > > > > My paperwork is now complete, if that's the only thing holding up this patch. > > Thanks. Could you please re-submit your patch, and add to it suitable > changes to NEWS and to the ELisp manual? Eli, if you still think this is something that should be done, I can add the NEWS entry and the manual changes. I've re-spun the patch for the current trunk: diff --git a/lisp/subr.el b/lisp/subr.el index e361b8324f..8cb8bcef69 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -143,11 +143,22 @@ setq-default (push `(set-default ',(pop args) ,(pop args)) exps)) `(progn . ,(nreverse exps)))) -(defmacro setq-local (var val) - "Set variable VAR to value VAL in current buffer." +(defmacro setq-local (&rest args) + "Set each SYM to the value of its VAL in the current buffer. + +\(fn [SYM VAL]...)" ;; Can't use backquote here, it's too early in the bootstrap. (declare (debug (symbolp form))) - (list 'set (list 'make-local-variable (list 'quote var)) val)) + (let ((expr)) + (while args + (setq expr + (cons + (list 'set + (list 'make-local-variable (list 'quote (car args))) + (car (cdr args))) + expr)) + (setq args (cdr (cdr args)))) + (cons 'progn (nreverse expr)))) (defmacro defvar-local (var val &optional docstring) "Define VAR as a buffer-local variable with default value VAL. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no