From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: dick.r.chiang@gmail.com
Cc: 37926@debbugs.gnu.org
Subject: bug#37926: [PATCH] Unify Gnus select methods
Date: Sat, 26 Oct 2019 13:21:27 -0700 [thread overview]
Message-ID: <877e4r5kc8.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87zhhoh9kn.fsf@dick> (dick r. chiang's message of "Fri, 25 Oct 2019 16:08:40 -0400")
dick.r.chiang@gmail.com writes:
> From d4654ad8f3412c79fa7d29427e66d2b964d5e191 Mon Sep 17 00:00:00 2001
> From: dickmao <none>
> Date: Mon, 30 Sep 2019 09:13:38 -0400
> Subject: [PATCH] Unify gnus select methods into one defcustom
This seems like a good idea in general. Gnus users are often unwilling
to update their configs, but in this case I doubt anyone's really keen
on retaining the primary/secondary distinction -- there's not much point
to it. All the same, it's probably worth floating on gnus.general.
My only note would be to add plenty of code comments (around the
defcustoms) explaining what's going on here. I've considered making this
change in the past, but it didn't quite seem worth it unless we could
actually simplify the code -- doing away with gnus-select-method and
gnus-secondary-select-methods altogether. In a way your patch sort of
complicates things, in that a year from now a bug-hunter is going to
have to familiarize themselves with the hows and whys of the
relationship between those options and gnus-select-methods. In a
codebase that already contains a lot of mystery, I think it's important
to note explicitly what's been done.
Thanks,
Eric
next prev parent reply other threads:[~2019-10-26 20:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 20:08 bug#37926: [PATCH] Unify Gnus select methods dick.r.chiang
2019-10-26 20:21 ` Eric Abrahamsen [this message]
2019-10-26 20:59 ` Andreas Schwab
2019-11-02 13:09 ` Deus Max
2019-11-02 13:36 ` Andreas Schwab
2019-11-02 14:09 ` Deus Max
2019-11-02 14:26 ` Andreas Schwab
2019-10-27 14:01 ` Lars Ingebrigtsen
2019-10-27 18:21 ` Eric Abrahamsen
2019-11-02 13:41 ` Deus Max
2019-11-02 14:10 ` dick.r.chiang
2019-11-02 14:52 ` Deus Max
2019-11-02 21:10 ` Eric Abrahamsen
2019-10-28 3:55 ` dick.r.chiang
2019-10-28 11:20 ` Lars Ingebrigtsen
2019-10-28 13:54 ` dick.r.chiang
2019-10-28 14:03 ` Lars Ingebrigtsen
2019-10-29 6:05 ` dick.r.chiang
2019-10-29 12:04 ` Lars Ingebrigtsen
2019-10-29 16:35 ` dick.r.chiang
2019-11-17 9:56 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e4r5kc8.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=37926@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.