From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#39436: 27.0.60; Documentaion error for package-menu-hide-package Date: Sun, 09 Feb 2020 21:30:12 +0100 Message-ID: <877e0v7bcb.fsf@marxist.se> References: <24122.56063.455926.185727@cochabamba.vanoostrum.org> <83eev5e7qh.fsf@gnu.org> <83zhdtcfpf.fsf@gnu.org> <83ftfjd5tv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="111798"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39436@debbugs.gnu.org To: Pieter van Oostrum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 09 21:31:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j0tEh-000T0a-2j for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Feb 2020 21:31:23 +0100 Original-Received: from localhost ([::1]:54272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0tEg-0006dO-5h for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Feb 2020 15:31:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38695) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0tEM-0006aO-Ox for bug-gnu-emacs@gnu.org; Sun, 09 Feb 2020 15:31:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0tEL-0004FE-Rl for bug-gnu-emacs@gnu.org; Sun, 09 Feb 2020 15:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47292) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j0tEL-0004El-Nu for bug-gnu-emacs@gnu.org; Sun, 09 Feb 2020 15:31:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j0tEL-0004Vh-LX for bug-gnu-emacs@gnu.org; Sun, 09 Feb 2020 15:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Feb 2020 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39436 X-GNU-PR-Package: emacs Original-Received: via spool by 39436-submit@debbugs.gnu.org id=B39436.158128022517289 (code B ref 39436); Sun, 09 Feb 2020 20:31:01 +0000 Original-Received: (at 39436) by debbugs.gnu.org; 9 Feb 2020 20:30:25 +0000 Original-Received: from localhost ([127.0.0.1]:53265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0tDk-0004Un-Uu for submit@debbugs.gnu.org; Sun, 09 Feb 2020 15:30:25 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:45570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0tDj-0004Ua-Kd for 39436@debbugs.gnu.org; Sun, 09 Feb 2020 15:30:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cyLZvL/nc58Xw/ZlmzWizPPmzm2LSpkcJwF3CE14Bbg=; b=IqbO+yGtMcQr/vzWbQ+v+2rKQi 2Er4AQAe9PbKsZurVSBDdMjnrQakBO1SDsscPoGEx1ccSI/JBnt5Y47tN/WcGbsDOfIC3726Rzlzy lxl/83LC1YM57rMlJN4rnW2J0AgVrWBcq6cJdTCq6FhL62EMu543bxDRqAIYz1QLzD0PpZY/IWL4c lbZ+FQrKt+DNNZWlfiOMnz/YbuSrapC42R0VjeLnpBH0VrnRkDJPC/1jxVm6XQESfDaWa15ap25n6 djHr2JucGQ1mg3I728jUh1CzlMa8aP156r8pJpGUn6nIJGDDeh6iAsLWxtMqjwWYBfR6+jIqwyz5w pssdvlEQ==; Original-Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:35988 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j0tDd-000Dq2-0z; Sun, 09 Feb 2020 15:30:17 -0500 In-Reply-To: (Pieter van Oostrum's message of "Sun, 09 Feb 2020 20:44:25 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175840 Archived-At: Pieter van Oostrum writes: > And it changed revert-buffer to also load the package list, by setting > 'revert-buffer-function' to the internal function 'package-menu--refresh'. But > the menu entry "Redisplay buffer" was not removed, and it actually is wrong now, > because it doesn't conditionally activate it on '(not > package--downloads-in-progress)'. Indeed. Note that the condition here is probably a bit simplistic; see Bug#39187. I'm working on implementing the fix suggested there, and will add a reminder to also change this menu entry. IOW, we can leave it as is in the context of this bug. > So I think this is the one that should be removed (also because it > does more than just redisplaying the buffer). I think that's the > only change that is necessary. Agreed. Best regards, Stefan Kangas