From: Jack Kamm <jackkamm@gmail.com>
To: John Kitchin <jkitchin@andrew.cmu.edu>
Cc: Bastien <bzg@gnu.org>, org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] (Tiny) Tweak Python session null return value
Date: Mon, 17 Feb 2020 11:05:44 -0800 [thread overview]
Message-ID: <877e0lf307.fsf@gmail.com> (raw)
In-Reply-To: <CAJ51ETosGFnpYJibQVVMXes_48LfsV5YSWFaosHGFpUxf3g4=A@mail.gmail.com>
Hi John,
John Kitchin <jkitchin@andrew.cmu.edu> writes:
> I think None is correct. If you don't specify a return value in Python,
> then a function returns None. I would expect that to happen in a Python
> block too.
Hmm, OK, thanks for your intuition, it's useful feedback.
Working this out loud, I was considering the following sort of block:
#+begin_src python :session :results value
if some_condition:
True
else:
False
#+end_src
#+RESULTS:
: None
Ideally, it would return True/False, but the current implementation
cannot grab that result unfortunately. (In its defense, it at least
doesn't crash like it did before).
I was thinking not printing anything at all under "#+RESULTS" would be
less surprising than printing "None". But both are admittedly surprising
at first.
I agree your preference of returning "None" is the more technically
consistent behavior though.
I don't want to rush a decision now, I think I need to gather more user
feedback after the 9.4 release. I'll ask Bastien to revert that commit
and put this off to 9.5, rather than writing an updated NEWS entry like
he asked.
Either way, we'll need to update Worg to clearly document what's going
on here.
next prev parent reply other threads:[~2020-02-17 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 16:24 [PATCH] (Tiny) Tweak Python session null return value Jack Kamm
2020-02-17 17:42 ` Bastien
2020-02-17 19:07 ` Jack Kamm
2020-02-17 22:53 ` Bastien
2020-02-17 17:52 ` John Kitchin
2020-02-17 19:05 ` Jack Kamm [this message]
2020-02-17 19:45 ` John Kitchin
2020-02-17 20:45 ` Jack Kamm
2020-02-17 22:27 ` John Kitchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e0lf307.fsf@gmail.com \
--to=jackkamm@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=jkitchin@andrew.cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.