From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39994: 27.0.90; Broken image-converter probe for imagemagick Date: Mon, 09 Mar 2020 10:15:03 +0100 Message-ID: <877dztopns.fsf@gnus.org> References: <87d09mpexq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="25029"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39994@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 09 10:16:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jBEWC-0006QO-KL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Mar 2020 10:16:12 +0100 Original-Received: from localhost ([::1]:39174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBEWB-0004qF-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Mar 2020 05:16:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55188) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBEW2-0004pq-RA for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2020 05:16:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBEW1-0008BG-Pv for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2020 05:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43826) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBEW1-0008B6-Ml for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2020 05:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBEW1-0000Pj-IY for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2020 05:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Mar 2020 09:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39994-submit@debbugs.gnu.org id=B39994.158374531531789 (code B ref 39994); Mon, 09 Mar 2020 09:16:01 +0000 Original-Received: (at 39994) by debbugs.gnu.org; 9 Mar 2020 09:15:15 +0000 Original-Received: from localhost ([127.0.0.1]:49799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBEVH-0008GI-4N for submit@debbugs.gnu.org; Mon, 09 Mar 2020 05:15:15 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBEVF-00089n-GM for 39994@debbugs.gnu.org; Mon, 09 Mar 2020 05:15:13 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jBEV6-0007Wn-2I; Mon, 09 Mar 2020 10:15:06 +0100 In-Reply-To: <87d09mpexq.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 09 Mar 2020 02:09:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177085 Archived-At: Juri Linkov writes: > Then I tried imagemagick, but image-converter said .ico format is unsupported. > Whereas running `convert -list format` outputs: > > Format Module Mode Description > ------------------------------------------------------------------------------- > ICO* ICON rw+ Microsoft icon > > So this patch adds the support for the 'Module' column to imagemagick probe: Ah, so some versions have an additional column in there? My convert -list format outputs: ICO* rw+ Microsoft icon > (defvar image-converter--converters > '((graphicsmagick :command ("gm" "convert") :probe ("-list" "format")) > - (ffmpeg :command "ffmpeg" :probe "-decoders") > - (imagemagick :command "convert" :probe ("-list" "format"))) > + (imagemagick :command "convert" :probe ("-list" "format")) > + (ffmpeg :command "ffmpeg" :probe "-decoders")) > "List of supported image converters to try.") Was this part included by mistake? It changes the order the converters are tested. > ;; Lines look like > ;; " WPG* r-- Word Perfect Graphics". > - (while (re-search-forward "^ *\\([A-Z0-9]+\\)\\*? +r" nil t) > + (while (re-search-forward "^ *\\([A-Z0-9]+\\)\\*?\\(?: +[A-Z0-9]+\\)? +r" nil t) Look OK to me, but the comment should be amended to reflect the two different line formats it's now matching. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no