From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: 39994@debbugs.gnu.org
Subject: bug#39994: 27.0.90; Broken image-converter probe for imagemagick
Date: Mon, 09 Mar 2020 10:15:03 +0100 [thread overview]
Message-ID: <877dztopns.fsf@gnus.org> (raw)
In-Reply-To: <87d09mpexq.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 09 Mar 2020 02:09:05 +0200")
Juri Linkov <juri@linkov.net> writes:
> Then I tried imagemagick, but image-converter said .ico format is unsupported.
> Whereas running `convert -list format` outputs:
>
> Format Module Mode Description
> -------------------------------------------------------------------------------
> ICO* ICON rw+ Microsoft icon
>
> So this patch adds the support for the 'Module' column to imagemagick probe:
Ah, so some versions have an additional column in there? My convert
-list format outputs:
ICO* rw+ Microsoft icon
> (defvar image-converter--converters
> '((graphicsmagick :command ("gm" "convert") :probe ("-list" "format"))
> - (ffmpeg :command "ffmpeg" :probe "-decoders")
> - (imagemagick :command "convert" :probe ("-list" "format")))
> + (imagemagick :command "convert" :probe ("-list" "format"))
> + (ffmpeg :command "ffmpeg" :probe "-decoders"))
> "List of supported image converters to try.")
Was this part included by mistake? It changes the order the converters
are tested.
> ;; Lines look like
> ;; " WPG* r-- Word Perfect Graphics".
> - (while (re-search-forward "^ *\\([A-Z0-9]+\\)\\*? +r" nil t)
> + (while (re-search-forward "^ *\\([A-Z0-9]+\\)\\*?\\(?: +[A-Z0-9]+\\)? +r" nil t)
Look OK to me, but the comment should be amended to reflect the two
different line formats it's now matching.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-03-09 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 0:09 bug#39994: 27.0.90; Broken image-converter probe for imagemagick Juri Linkov
2020-03-09 9:15 ` Lars Ingebrigtsen [this message]
2020-03-09 22:43 ` Juri Linkov
2020-03-14 12:02 ` Lars Ingebrigtsen
2020-03-15 0:00 ` Juri Linkov
2020-03-16 0:04 ` Juri Linkov
2020-03-29 23:16 ` Juri Linkov
2020-03-16 0:23 ` Juri Linkov
2020-08-02 7:56 ` Lars Ingebrigtsen
2020-08-02 23:31 ` Juri Linkov
2020-08-03 7:15 ` Lars Ingebrigtsen
2020-08-03 23:42 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dztopns.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=39994@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.