From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Juan José García-Ripoll" <juanjose.garciaripoll@gmail.com>,
emacs-devel@gnu.org
Subject: Re: GDI+ take 3
Date: Tue, 14 Apr 2020 20:08:45 +0100 [thread overview]
Message-ID: <877dyh28ci.fsf@tcd.ie> (raw)
In-Reply-To: <837dyihyjc.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Apr 2020 18:33:59 +0300")
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Testing and bug reports about this new feature are welcome.
No testing, just a compiler warning:
image.c:6240:1: warning: ‘image_can_use_native_api’ defined but not used [-Wunused-function]
6240 | image_can_use_native_api (Lisp_Object type)
| ^~~~~~~~~~~~~~~~~~~~~~~~
Is the following okay as a fix?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-warning-from-recent-native-image-API-changes.patch --]
[-- Type: text/x-diff, Size: 1008 bytes --]
From 31ba44075d766e3ccf0f0bf65c17e1d9944b03f5 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Tue, 14 Apr 2020 19:37:28 +0100
Subject: [PATCH] Fix warning from recent native image API changes
* src/image.c (image_can_use_native_api) [HAVE_NATIVE_IMAGE_API]:
Define static function only if it will be used.
---
src/image.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/image.c b/src/image.c
index aacaf0b734..039fd1bd63 100644
--- a/src/image.c
+++ b/src/image.c
@@ -6236,19 +6236,17 @@ pbm_load (struct frame *f, struct image *img)
NATIVE IMAGE HANDLING
***********************************************************************/
+#if HAVE_NATIVE_IMAGE_API
static bool
image_can_use_native_api (Lisp_Object type)
{
-#if HAVE_NATIVE_IMAGE_API
# ifdef HAVE_NTGUI
return w32_can_use_native_image_api (type);
# else
return false;
# endif
-#else
- return false;
-#endif
}
+#endif
#if HAVE_NATIVE_IMAGE_API
--
2.25.1
[-- Attachment #3: Type: text/plain, Size: 829 bytes --]
Thanks,
--
Basil
In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
of 2020-04-14 built on thunk
Repository revision: 439e578532279507f45519c67eb84d5b7bbba8b6
Repository branch: blc/image-native-warning
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid
Configured using:
'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
--prefix=/home/blc/.local --with-x-toolkit=lucid
--with-file-notification=yes --with-x'
Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB
NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT
LIBOTF ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS
LIBSYSTEMD JSON PDUMPER LCMS2 GMP
next prev parent reply other threads:[~2020-04-14 19:08 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 21:25 GDI+ take 3 Juan José García-Ripoll
2020-04-05 12:58 ` Eli Zaretskii
2020-04-13 6:19 ` Eli Zaretskii
2020-04-13 10:04 ` Juan José García-Ripoll
2020-04-14 15:33 ` Eli Zaretskii
2020-04-14 17:43 ` Eli Zaretskii
2020-04-14 22:19 ` Alan Third
2020-04-16 18:39 ` Eli Zaretskii
2020-04-14 18:38 ` Dmitry Gutov
2020-04-14 18:43 ` Eli Zaretskii
2020-04-14 19:38 ` Dmitry Gutov
2020-04-14 19:08 ` Basil L. Contovounesios [this message]
2020-04-14 19:24 ` Eli Zaretskii
2020-04-14 21:57 ` Basil L. Contovounesios
2020-04-15 6:18 ` Eli Zaretskii
2020-04-15 13:40 ` Juanma Barranquero
2020-04-15 14:00 ` Eli Zaretskii
2020-04-15 14:12 ` Juanma Barranquero
2020-04-15 14:17 ` Juanma Barranquero
2020-04-15 14:28 ` Eli Zaretskii
2020-04-15 14:35 ` Juanma Barranquero
2020-04-15 14:43 ` Eli Zaretskii
2020-04-15 14:47 ` Juanma Barranquero
2020-04-15 15:00 ` Juanma Barranquero
2020-04-15 15:02 ` Juanma Barranquero
2020-04-15 15:10 ` Eli Zaretskii
2020-04-15 15:31 ` Juanma Barranquero
2020-04-15 15:46 ` Eli Zaretskii
2020-04-15 15:56 ` Eli Zaretskii
2020-04-15 16:08 ` Eli Zaretskii
2020-04-15 16:50 ` Juanma Barranquero
2020-04-15 16:59 ` Eli Zaretskii
2020-04-15 17:24 ` Juanma Barranquero
2020-04-15 17:34 ` Eli Zaretskii
2020-04-15 17:49 ` Juanma Barranquero
2020-04-15 18:13 ` Eli Zaretskii
2020-04-15 18:45 ` Juanma Barranquero
2020-04-15 20:21 ` Eli Zaretskii
2020-04-15 20:31 ` Juanma Barranquero
2020-04-16 10:04 ` Eli Zaretskii
2020-04-16 23:49 ` Juanma Barranquero
2020-04-17 6:55 ` Eli Zaretskii
2020-04-17 7:27 ` Juan José García-Ripoll
2020-04-17 8:36 ` Juanma Barranquero
2020-04-17 9:52 ` Eli Zaretskii
2020-04-18 8:41 ` Juan José García-Ripoll
2020-04-18 10:00 ` Eli Zaretskii
2020-04-18 10:09 ` Juanma Barranquero
2020-04-18 12:38 ` Juan José García-Ripoll
2020-04-18 13:38 ` Eli Zaretskii
2020-04-18 15:56 ` Juanma Barranquero
2020-04-18 16:15 ` Eli Zaretskii
2020-04-18 17:51 ` Juan José García-Ripoll
2020-04-18 18:01 ` Eli Zaretskii
2020-04-18 18:04 ` Eli Zaretskii
2020-04-18 18:49 ` Juanma Barranquero
2020-04-18 19:15 ` Eli Zaretskii
2020-04-18 20:19 ` Alan Third
2020-04-19 10:20 ` Juan José García-Ripoll
2020-04-19 20:08 ` Juan José García-Ripoll
2020-04-20 13:37 ` Eli Zaretskii
2020-04-21 7:35 ` Juan José García-Ripoll
2020-04-21 14:15 ` Eli Zaretskii
2020-04-21 18:17 ` Alan Third
2020-04-21 18:34 ` Eli Zaretskii
2020-04-25 16:51 ` Alan Third
2020-04-20 20:16 ` Alan Third
2020-04-21 6:25 ` Juan José García-Ripoll
2020-04-25 16:23 ` Alan Third
2020-04-25 13:42 ` Eli Zaretskii
2020-04-26 15:14 ` Juan José García-Ripoll
2020-04-19 18:16 ` Eli Zaretskii
2020-04-19 20:28 ` Juan José García-Ripoll
2020-04-20 13:54 ` Eli Zaretskii
2020-04-21 6:44 ` Juan José García-Ripoll
2020-04-21 14:13 ` Eli Zaretskii
2020-04-21 16:20 ` Juan José García-Ripoll
2020-04-15 16:50 ` Eli Zaretskii
2020-04-15 14:27 ` Eli Zaretskii
[not found] <617217672.240027.1586079490291@mail1.libero.it>
2020-04-15 14:07 ` Angelo Graziosi
2020-04-15 14:15 ` Eli Zaretskii
2020-04-15 14:22 ` Angelo Graziosi
2020-04-15 14:26 ` Eli Zaretskii
2020-04-15 15:25 ` Angelo Graziosi
2020-04-15 15:27 ` Eli Zaretskii
2020-04-15 15:46 ` Angelo Graziosi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dyh28ci.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juanjose.garciaripoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.