From: Noam Postavsky <npostavs@gmail.com>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 29866@debbugs.gnu.org
Subject: bug#29866: 27.0.50; cl-loop: Calculate the array length just once
Date: Tue, 05 May 2020 22:21:36 -0400 [thread overview]
Message-ID: <877dxpn6q7.fsf@gmail.com> (raw)
In-Reply-To: <87wp18179m.fsf@gmail.com> (Tino Calancha's message of "Thu, 28 Dec 2017 01:10:29 +0900")
tags 29866 - patch
tags 29866 + wontfix
quit
Tino Calancha <tino.calancha@gmail.com> writes:
> (let ((temp-vec (make-symbol "--cl-vec--"))
> + (temp-len (make-symbol "--cl-len--"))
> (temp-idx (make-symbol "--cl-idx--")))
> (push (list temp-vec (pop cl--loop-args)) loop-for-bindings)
> + (push (list temp-len `(length ,temp-vec)) loop-for-bindings)
> (push (list temp-idx -1) loop-for-bindings)
I reverted this because it breaks with 'and' because the bindings are
made with 'let' rather than 'let*' (see Bug#40727). I'm marking wontfix
because I don't intend to anything more about it, but I wouldn't oppose
another attempt that didn't have this problem (I think it would require
extensive code changes though).
prev parent reply other threads:[~2020-05-06 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 16:10 bug#29866: 27.0.50; cl-loop: Calculate the array length just once Tino Calancha
2017-12-27 20:13 ` Tino Calancha
2017-12-27 20:20 ` Lars Ingebrigtsen
2017-12-27 20:54 ` Stefan Monnier
2017-12-27 21:36 ` Tino Calancha
2017-12-28 1:27 ` Drew Adams
2017-12-28 1:49 ` Noam Postavsky
2017-12-28 1:52 ` Drew Adams
2017-12-28 2:39 ` Stefan Monnier
2017-12-28 17:21 ` Tino Calancha
2018-01-07 15:39 ` Tino Calancha
2020-05-06 2:21 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dxpn6q7.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=29866@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.