all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 42112@debbugs.gnu.org
Subject: bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL
Date: Sun, 28 Jun 2020 18:34:56 +0100	[thread overview]
Message-ID: <877dvrt7pb.fsf@tcd.ie> (raw)
In-Reply-To: <837dvr2kst.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 28 Jun 2020 19:54:10 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Sun, 28 Jun 2020 17:41:48 +0100
>> 
>> 0. emacs -Q
>> 1. M-x whitespace-mode RET
>> 2. M-<
>> 
>> In Emacs 26, line 3 is highlighted with the whitespace-empty face all
>> the way to the right fringe.
>> 
>> In Emacs 27, only the first two columns of line 3 are highlighted with
>> the whitespace-empty face.
>> 
>> Is this TRT?
>
> I don't know: I don't use this mode.

I do, but I'm not sure what constitutes correct behaviour.  I guess the
Emacs 26 behaviour is how the feature was designed and what users have
come to expect, in which case Emacs 27 exhibits a regression.

>> Should whitespace-empty get an ':extend t' attribute or inherit from
>> some other face which already has that?
>
> If we want the empty lines to be shown in this face in their entirety,
> then it should have the :extend attribute, yes.

Is there any practical difference or preference between giving
whitespace-empty an :extend attribute vs making it inherit from a face
with an :extend attribute?

> Just make sure it looks OK with underline and other non-color
> attributes.

Will do in about a week's time if no-one beats me to it.

Thanks,

-- 
Basil





  reply	other threads:[~2020-06-28 17:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 16:41 bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL Basil L. Contovounesios
2020-06-28 16:54 ` Eli Zaretskii
2020-06-28 17:34   ` Basil L. Contovounesios [this message]
2020-06-28 18:17     ` Eli Zaretskii
2021-07-31 14:53 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dvrt7pb.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=42112@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.