From: "Mingde (Matthew) Zeng" <matthewzmd@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "Mingde \(Matthew\) Zeng" <matthewzmd@gmail.com>,
34657@debbugs.gnu.org, bandali@gnu.org
Subject: bug#34657: [PATCH] erc: fix erc-reuse-buffers (bug#40121)
Date: Sun, 09 Aug 2020 23:34:31 -0400 [thread overview]
Message-ID: <877du7gomw.fsf@gmail.com> (raw)
In-Reply-To: <87k0y8umbz.fsf@gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
> (Note that I've moved this from emacs-devel to the bug report.)
>
> "Mingde (Matthew) Zeng" <matthewzmd@gmail.com> writes:
>
>> * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is
>> always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it
>> will always use the first candidate, resulting in behavior 1.
>
> Is this correct, though?
Incorrect (after our previous discussion), I'll change it in my next patch.
>
> Otherwise I think the patch looks OK, but there's unfortunately been
> further changes to these functions, and your patch no longer applies.
> Can you re-spin the patch?
Sure, but in a day or two, a bit busy at the moment.
Matthew
--
Mingde (Matthew) Zeng
prev parent reply other threads:[~2020-08-10 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 2:30 [PATCH] erc: fix erc-reuse-buffers (bug#40121) Mingde (Matthew) Zeng
2020-08-09 10:48 ` bug#34657: " Lars Ingebrigtsen
2020-08-10 3:34 ` Mingde (Matthew) Zeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877du7gomw.fsf@gmail.com \
--to=matthewzmd@gmail.com \
--cc=34657@debbugs.gnu.org \
--cc=bandali@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.