From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36403: 27.0.50; Trivial image.c bugs Date: Fri, 21 Aug 2020 13:26:25 +0200 Message-ID: <877dts8cke.fsf@gnus.org> References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24051"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Alan Third , 36403@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 13:47:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k95Vx-0006Az-Dw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 13:47:21 +0200 Original-Received: from localhost ([::1]:51944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k95Vw-0002a6-Bp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 07:47:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k95CI-0005KT-Cn for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 07:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k95CI-0000sq-19 for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 07:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k95CH-0003BU-TF for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 07:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 11:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159800920012206 (code B ref 36403); Fri, 21 Aug 2020 11:27:01 +0000 Original-Received: (at 36403) by debbugs.gnu.org; 21 Aug 2020 11:26:40 +0000 Original-Received: from localhost ([127.0.0.1]:45153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95Bv-0003An-Gk for submit@debbugs.gnu.org; Fri, 21 Aug 2020 07:26:39 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95Bt-0003AZ-Bz for 36403@debbugs.gnu.org; Fri, 21 Aug 2020 07:26:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ob7SvlUlzppTE5ULRP6vXY5DSCedrj2GJgUk+lRgo1A=; b=XWAPbaYwFCH8a3Z7yPZDg2/g2m TF5od+snRScLkDgiiVSiPwbhjWCZ/rjce+cHo3Z8llyLMkbiJyKBMfbQ4C/oH/I43dlfs1dm6xHQB iP5sXfQ3Bil/TmfRQSckkshckJ9CnDaGinHqc/DlvKjuRjSmO2YucjN6XLY0XmPBoQ7E=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k95Bj-0002wG-CK; Fri, 21 Aug 2020 13:26:30 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXt49Tws6X3YVj/ //9yIEcRAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QIFQsDKup1aqwAAAE+SURBVCjPnZLBasMwDIbl 4oyuJwfiwnJfoX0KBZoedlIgDltOOaxj61P0tHM7KPQBktL6KScrTe6bwcaf/UeRfhngn0M5hyOU AHbYR+GS7pCMCx8GvVU4qFhU0qBSDlWv46OIHKwFWGy7tzKT73kuSOWIPbjXxpKABjh/lDNCwzAF db7oTUkBnlaT5khZQiF26o+HE1otMPcXrBC14dyh8C1xObpoGTJXkFkbVV0lgSXE68RubgIpzHUS vfQww0eyLh0gYkfuMMl5T6sAOT4TF2h3AeJrhcEsH0KbbWbYFPoJPzWzIkalslzA3nSo2DShOLPc BtgLLHwnVh7CWnifcdYghnwLTHt/a3+zCJ9KTIx3vj65dwkJD/bLseNGYIKJrfbNvZEEkcu7sXOR q9uh2ayox3ZbqWEYzv3l2fwCz29Ia1iemN0AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgtMjFU MTE6MDM6NDErMDA6MDD2+vyfAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA4LTIxVDExOjAzOjQx KzAwOjAwh6dEIwAAAABJRU5ErkJggg== X-Now-Playing: Renaldo and the Loaf's _Songs for Swinging Larvae & Songs from the Surgery_: "Songs From The Surgery" In-Reply-To: (Pip Cet's message of "Fri, 21 Aug 2020 09:26:10 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185837 Archived-At: Pip Cet writes: > Paul's suggestion was to use equal () instead of !NILP (Fequal (...)). > I'm against that, because the F in Fequal kind of hints at the > difficulties of using equal, of which there are many: in the current > implementation, it can signal, quit, be asymmetric (signalling for > (equal a b) whereas (equal b a) works), and is susceptible to equality > bombs that take forever to compare. Yeah, your equal_lists is better in all ways, I think. It should be much faster, too -- Fequal on a list checks whether the string members are equal, too, which is slow. So I think this will speed things up if you have a buffer that displays images where the data comes from a string (which can be huge) instead of a file. > Replacing !NILP is a better idea, but I'm struggling to come up with a > good name for that. But even a bad name would be an improvement. TRUEP is kinda obvious, isn't it? Although I guess some people would object on the grounds that only t is true, while all other non-nil values are only trueish. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no