From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43359: package-tests leave temporary files behind Date: Sun, 13 Sep 2020 16:32:33 +0200 Message-ID: <877dsxwxvi.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10757"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43359@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 13 16:33:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHT43-0002ga-09 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 16:33:11 +0200 Original-Received: from localhost ([::1]:55652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHT42-0007cV-31 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 10:33:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHT3u-0007cN-7X for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 10:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHT3t-0006Cx-UU for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 10:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHT3t-00047a-S5 for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 10:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43359 X-GNU-PR-Package: emacs Original-Received: via spool by 43359-submit@debbugs.gnu.org id=B43359.160000757115822 (code B ref 43359); Sun, 13 Sep 2020 14:33:01 +0000 Original-Received: (at 43359) by debbugs.gnu.org; 13 Sep 2020 14:32:51 +0000 Original-Received: from localhost ([127.0.0.1]:51275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHT3j-000477-5u for submit@debbugs.gnu.org; Sun, 13 Sep 2020 10:32:51 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHT3g-00046q-BF for 43359@debbugs.gnu.org; Sun, 13 Sep 2020 10:32:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UzIGk9cx7pY/6flZBFWXLHXuzkKSpZGZMDRlOyAVnJg=; b=cwZ7QjWgGgbqWY/4BkVCAgXIQY 2Wp78+T6d0pwieqmkY9G6La94zbsXTA4Ka+T1j0K97IQuHLtcYOr7TzBeohD+ZMoWmkE2jnmgbBdG 6bf8u0ayf34Dlm3x/W4MWX1x5zkKEFLDS5mC1VZmN8dny45Zt6NNY04a1nfzyOcv+LGA=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHT3T-0003uj-A3; Sun, 13 Sep 2020 16:32:42 +0200 X-Now-Playing: KiTsuNe and Brian the Fox's _The Future Eve_: "(untitled)" In-Reply-To: (Glenn Morris's message of "Sat, 12 Sep 2020 14:02:06 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187954 Archived-At: Glenn Morris writes: > cd test > make lisp/emacs-lisp/package-tests > > -> two directories "/tmp/pkg-archive-base-*" are left behind on every run. This patch fixes the problem, but since it does a recursive deletion, it'd be nice if somebody could look at it and see whether it looks safe... I think it should be -- when upload-base is set, then package-test-archive-upload-base should always point to the new directory in /tmp. diff --git a/test/lisp/emacs-lisp/package-tests.el b/test/lisp/emacs-lisp/package-tests.el index cbb2410f95..7797799cf8 100644 --- a/test/lisp/emacs-lisp/package-tests.el +++ b/test/lisp/emacs-lisp/package-tests.el @@ -154,6 +154,8 @@ with-package-test `(insert-file-contents ,file)) ,@body))) + (when ,upload-base + (delete-directory package-test-archive-upload-base t)) (when (file-directory-p package-test-user-dir) (delete-directory package-test-user-dir t)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no