From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22906: 24.5; eww SGML validate error Date: Tue, 15 Sep 2020 18:12:55 +0200 Message-ID: <877dsv588o.fsf@gnus.org> References: <8737s6i9yz.fsf@aol.com> <87bmzzhcy8.fsf@gmail.com> <87wpdkdrew.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19172"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 22906@debbugs.gnu.org, Live System User To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 15 18:14:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIDb8-0004pG-Gu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Sep 2020 18:14:26 +0200 Original-Received: from localhost ([::1]:57702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIDb7-0002RD-Bq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Sep 2020 12:14:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIDao-0002IV-2Q for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 12:14:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIDak-0002j5-Ne for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 12:14:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIDak-0000Zf-HU for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 12:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Sep 2020 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22906 X-GNU-PR-Package: emacs Original-Received: via spool by 22906-submit@debbugs.gnu.org id=B22906.16001863872123 (code B ref 22906); Tue, 15 Sep 2020 16:14:02 +0000 Original-Received: (at 22906) by debbugs.gnu.org; 15 Sep 2020 16:13:07 +0000 Original-Received: from localhost ([127.0.0.1]:60401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIDZr-0000Y9-1N for submit@debbugs.gnu.org; Tue, 15 Sep 2020 12:13:07 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIDZp-0000XV-PQ for 22906@debbugs.gnu.org; Tue, 15 Sep 2020 12:13:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XMowvgGWBptei+XT9VSggq1qE5aGz8Qjfqp70nfD7O8=; b=azpym0kAHkaOsDzb/BCOMUIJJC frzJ+Kcdzj6OsnYxvFFFrrbvjhAKu5o5h1JnVszIiURct9S0EqG5+LOvmHIMHOZNS8OGTtE6w/L+s SfaSgyhxBhhhw1xwjnATJHXeQJxjC5p6LelpgGw3W1Jp6iH331xYU6DRnVh4RgGdGXnA=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIDZg-00029j-Q3; Tue, 15 Sep 2020 18:12:59 +0200 X-Now-Playing: Saito Koji's _433-1_: "433_061" In-Reply-To: <87wpdkdrew.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 24 Jan 2017 23:28:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188137 Archived-At: Lars Ingebrigtsen writes: >> I can reproduce this on the current master branch (ec12c670). >> >> The issue seems to be that `sgml-validate' assumes that the buffer is >> visiting a file, which is not the case when you view a web page's source >> from eww. >> >> Maybe we could offer to save the buffer when it's not visiting a file? > > I think that would be unusual for commands like this (that have to be > written out to work). Instead it could save the buffer to a temporary > file, validate and then delete it again. Actually, looking at the code again, I think it's just a simple bug. It checks whether buffer-file-name is non-nil, but then it ends up with (shell-quote-argument nil), which is invalid. I've now fixed this in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no