all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mattiase@acm.org, 43598@debbugs.gnu.org
Subject: bug#43598: replace-in-string: finishing touches
Date: Fri, 25 Sep 2020 12:09:16 +0200	[thread overview]
Message-ID: <877dsirwvn.fsf@gnus.org> (raw)
In-Reply-To: <834knmtdna.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 25 Sep 2020 12:21:45 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> Would it help to always convert the first argument of
> replace-in-string to a multibyte string, before replacing?

Yes, but not when the third argument is a unibyte string.

I've now done the conversion in the new string-search C-level function,
converting the search string both ways, depending on what the HAYSTACK
string is.  I'm not 100% sure that I'm doing the right thing here,
though, but it seems to pass all the test cases I could come up with.  I
wrote it very late last night, though, so...  :-/

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-09-25 10:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 20:52 bug#43598: replace-in-string: finishing touches Mattias Engdegård
2020-09-24 21:12 ` Lars Ingebrigtsen
2020-09-24 21:19 ` Lars Ingebrigtsen
2020-09-24 23:18   ` Lars Ingebrigtsen
2020-09-25  9:21     ` Eli Zaretskii
2020-09-25 10:09       ` Lars Ingebrigtsen [this message]
2020-09-24 23:54 ` Lars Ingebrigtsen
2020-09-25 10:42   ` Mattias Engdegård
2020-09-25 11:11     ` Lars Ingebrigtsen
2020-09-25 11:22       ` Mattias Engdegård
2020-09-25 11:32         ` Lars Ingebrigtsen
2020-09-27  0:03         ` Lars Ingebrigtsen
2020-09-27  0:34           ` Lars Ingebrigtsen
2020-09-27  8:45             ` Mattias Engdegård
2020-09-28  3:41             ` Richard Stallman
2020-09-28  9:40               ` Mattias Engdegård
2020-09-29  3:29                 ` Richard Stallman
2020-09-29  4:12                   ` Eli Zaretskii
2020-09-27 11:12           ` Mattias Engdegård
2020-09-27 11:48             ` Lars Ingebrigtsen
2020-09-27 11:57               ` Mattias Engdegård
2020-09-27 12:02                 ` Lars Ingebrigtsen
2020-09-27 16:14                   ` Mattias Engdegård
2020-09-27 16:19                     ` Eli Zaretskii
2020-09-27 16:41                       ` Lars Ingebrigtsen
2020-09-27 16:48                         ` Eli Zaretskii
2020-09-26 22:44     ` Lars Ingebrigtsen
2020-09-26 22:25 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dsirwvn.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=43598@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.