From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44618: 26.3; bibtex.el ignores file variable bibtex-contline-indentation Date: Sat, 14 Nov 2020 17:20:34 +0100 Message-ID: <877dqnzz8t.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25969"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44618@debbugs.gnu.org To: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 14 17:21:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdyIa-0006ag-TL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 17:21:12 +0100 Original-Received: from localhost ([::1]:56414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdyIZ-0004Aw-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 11:21:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdyIR-00049K-Me for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:21:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdyIQ-0005yB-1E for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:21:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdyIP-0007Bx-TB for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 11:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2020 16:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44618 X-GNU-PR-Package: emacs Original-Received: via spool by 44618-submit@debbugs.gnu.org id=B44618.160537084627601 (code B ref 44618); Sat, 14 Nov 2020 16:21:01 +0000 Original-Received: (at 44618) by debbugs.gnu.org; 14 Nov 2020 16:20:46 +0000 Original-Received: from localhost ([127.0.0.1]:51726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdyIA-0007B7-4v for submit@debbugs.gnu.org; Sat, 14 Nov 2020 11:20:46 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:44156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdyI8-0007Ar-Ar for 44618@debbugs.gnu.org; Sat, 14 Nov 2020 11:20:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RHTEQJZzVc4eMK4dDR5kVDuI6JsdKPteX858N+HR68k=; b=XePvOXfrq+vcJT3zSTd3uAmlhB edugndn6eA6KT3d1qPqfHd1sTr/1I9wx3LoNQXozcowDYqi/KBTGDnBuAZc/mZwbqiwl0HoDuor2c Szg3qMlfFtn0oO87cQ51e6DMyItD+drL3KjiVyhCCmhUh6VKPS886iR6/BdtenQXQUFs=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdyHz-0000Zq-4m; Sat, 14 Nov 2020 17:20:37 +0100 X-Now-Playing: Genesis's _Duke_: "Heathaze" In-Reply-To: ("Francesco =?UTF-8?Q?Potort=C3=AC?="'s message of "Fri, 13 Nov 2020 13:45:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193297 Archived-At: Francesco Potort=C3=AC writes: > Whatever the reason, bibtex-mode sets fill-prefix as a local variable > irrespective of the file variable bibtex-contline-indentation. > > The fix for my case is simple: avoid setting fill-prefix as a local > variable in the minor mode, and just set it inside the > bibtex-fill-field-bounds function. A patch follows. > > However, I don't know if this is a hint of some more general problem on > how bibtex-mode trets file variables. [...] > - (set (make-local-variable 'fill-prefix) > - (make-string (+ bibtex-entry-offset bibtex-contline-indentation) = ?\s)) [...] > - (let ((end-field (copy-marker (bibtex-end-of-field bounds)))) > + (let ((fill-prefix > + (make-string (+ bibtex-entry-offset bibtex-contline-indentation) ?\s)) > + (end-field (copy-marker (bibtex-end-of-field bounds)))) This patch would make it impossible for people to alter fill-prefix (from the mode hook, for instance), so I don't think this is the right solution. Looking at hack-local-variables/normal-mode, file-local variables are set after the mode has been set up, so you can't have your mode set up variables based on file-local variables. (If I'm wrong here, please somebody correct me.) So you can't usefully set bibtex-entry-offset/bibtex-contline-indentation as file-local variables without also setting fill-prefix that way, I think? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no