From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Mon, 16 Nov 2020 22:23:47 +0200 Organization: LINKOV.NET Message-ID: <877dql59v0.fsf@mail.linkov.net> References: <20201115023629.19537.77471@vcs0.savannah.gnu.org> <20201115023631.C78AB20A27@vcs0.savannah.gnu.org> <20201115224943.o5r7lkkblmyt2ox4@Ergus> <20201116033719.63dryvqm4ozfer2r@Ergus> <92f3cbd7-29a0-461a-a023-562bc6020ea8@default> <87v9e5herj.fsf@mail.linkov.net> <20201116102729.ywubtda6cqdzc45z@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16495"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , Drew Adams , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 16 22:01:17 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kelcj-0004DJ-Lh for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 22:01:17 +0100 Original-Received: from localhost ([::1]:38210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kelci-00054E-Ng for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 16:01:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kelaz-0003v2-9A for emacs-devel@gnu.org; Mon, 16 Nov 2020 15:59:29 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kelax-0000Ay-By for emacs-devel@gnu.org; Mon, 16 Nov 2020 15:59:28 -0500 X-Originating-IP: 91.129.97.46 Original-Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46]) (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id ED436240002; Mon, 16 Nov 2020 20:59:20 +0000 (UTC) In-Reply-To: <20201116102729.ywubtda6cqdzc45z@Ergus> (Ergus's message of "Mon, 16 Nov 2020 11:27:29 +0100") Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 14:21:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259252 Archived-At: > With the current implementation this is not supposed to change. Of > course there is space for improvement and there are bugs, but so far, > all navigation still works in *Completions* buffer as usual because I > just added some commands. If there is anything that breaks the normal > previous behavior somehow, please tell me; because I put special > attention to prevent that. Sorry, I was not clear enough: I meant that the new feature doesn't allow in the minibuffer using the same navigation keys that are already available in the *Completions* buffer, e.g. and typed in the *Completions* buffer scroll it up and down. For example, while in the minibuffer type 'TAB' that displays a very long list of completions, then type 'C-M-v', and see how it scrolls the *Completions* buffer. Better yet try typing and in the minibuffer, and see how it scrolls the *Completions* buffer up and down. I meant that a new feature could allow such page scrolling without the 'M-' modifier, by just using and in the minibuffer (and C-v/M-v as well) to scroll the *Completions* buffer. > We could add a custom to disable the new bindings in the *Completions* > if you think is better; because IMO the most important thing is to > "navigate" with arrows the completions from the minibuffer without > leaving it; and the overlay. Maybe a custom could provide some DWIM behavior by default, e.g. to activate these keys only when the *Completions* buffer is displayed.