From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45617: loses the edit region. Works in 23.3, broke in 26.3 Date: Tue, 19 Jan 2021 19:43:42 +0200 Organization: LINKOV.NET Message-ID: <877do8eull.fsf@mail.linkov.net> References: <000001d6e16c$984bcb70$c8e36250$@net> <83turycc18.fsf@gnu.org> <87ble4ob6v.fsf@mail.linkov.net> <000601d6e2ea$8f6601e0$ae3205a0$@net> <877dorkznt.fsf@mail.linkov.net> <002701d6e39b$4ac35680$e04a0380$@net> <8735ze9e09.fsf@mail.linkov.net> <83mtxm0vzd.fsf@gnu.org> <002d01d6e478$ca50cdf0$5ef269d0$@net> <87k0sgirr0.fsf@mail.linkov.net> <002101d6eadc$e816a070$b843e150$@net> <87k0sezj07.fsf@mail.linkov.net> <000c01d6eb68$f3f675f0$dbe361d0$@net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 45617@debbugs.gnu.org To: "Bob Floyd" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 19 19:22:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1veC-0000aR-SB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 19:22:32 +0100 Original-Received: from localhost ([::1]:36560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1veB-0000CM-Op for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 13:22:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1vHU-0005At-0N for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 12:59:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1vHS-0004jy-Fq for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 12:59:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1vHS-0002Vm-En for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 12:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jan 2021 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45617 X-GNU-PR-Package: emacs Original-Received: via spool by 45617-submit@debbugs.gnu.org id=B45617.16110791409641 (code B ref 45617); Tue, 19 Jan 2021 17:59:02 +0000 Original-Received: (at 45617) by debbugs.gnu.org; 19 Jan 2021 17:59:00 +0000 Original-Received: from localhost ([127.0.0.1]:51583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1vHQ-0002VQ-Cn for submit@debbugs.gnu.org; Tue, 19 Jan 2021 12:59:00 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:54433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1vHN-0002Ut-OO for 45617@debbugs.gnu.org; Tue, 19 Jan 2021 12:58:58 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 2B45B20004; Tue, 19 Jan 2021 17:58:49 +0000 (UTC) In-Reply-To: <000c01d6eb68$f3f675f0$dbe361d0$@net> (Bob Floyd's message of "Fri, 15 Jan 2021 10:05:04 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198187 Archived-At: > I'm having an issue with the new patch. fails! Sorry, I tried your test case, but can't reproduce the problem. > 1. Select entire region by dragging mouse. > 2. Begin > In the command window: Query replace in region: > 3. Enter RL using the keyboard > In the command window: Query replace in region RL with: > 4. Now, with the mouse, select RL at line 12 ... > paramset P2 RL; <--- THIS ONE > ... then yank it to the command window and with keyboard enter X: The most important line of your test case is the line above, but I don't understand what you mean by yanking the selected text. I tried to drag the selected text "RL" to the minibuffer window, as all other apps allow to do, but Emacs fails to do the same. Please help to clarify how do you yank the selected text. > In the command window: Query replace in region RL with: RLX > 5. Enter > Only one of the two RL's in the region are selected, depending on > if the region was selected from top-to-bottom or bottom-to-top. > > It should select both RL's! It selects both RL's when I tried. > Just in case I misread the diff, this is the function as I have manually > patched it: > > (defun query-replace-read-args (prompt regexp-flag &optional noerror) > (unless noerror > (barf-if-buffer-read-only)) > (save-mark-and-excursion > (let* ((from (query-replace-read-from prompt regexp-flag)) > (to (if (consp from) (prog1 (cdr from) (setq from (car from))) > (query-replace-read-to from prompt regexp-flag)))) > (or (and current-prefix-arg (not (eq current-prefix-arg '-))) > (and (plist-member (text-properties-at 0 from) > 'isearch-regexp-function) > (get-text-property 0 'isearch-regexp-function from))) > (list from to > (and current-prefix-arg (not (eq current-prefix-arg '-))) > (and current-prefix-arg (eq current-prefix-arg '-)))))) This function is very much messed up. Please try the function below: (defun query-replace-read-args (prompt regexp-flag &optional noerror) (unless noerror (barf-if-buffer-read-only)) (save-mark-and-excursion (let* ((from (query-replace-read-from prompt regexp-flag)) (to (if (consp from) (prog1 (cdr from) (setq from (car from))) (query-replace-read-to from prompt regexp-flag)))) (list from to (or (and current-prefix-arg (not (eq current-prefix-arg '-))) (and (plist-member (text-properties-at 0 from) 'isearch-regexp-function) (get-text-property 0 'isearch-regexp-function from))) (and current-prefix-arg (eq current-prefix-arg '-))))))