bug#30129: 25.3; ibuffer sorting order does not return to normal after using `ibuffer-invert-sorting' twice

bug#30129: 25.3; ibuffer sorting order does not return to normal after using `ibuffer-invert-sorting' twice

[Windy Tusooa]

[-- Attachment #1: Type: text/plain, Size: 2947 bytes --]


Severity: normal

In ibuffer-mode, the command `ibuffer-invert-sorting’ reverse the order of buffers. But when the command is used the second time, the order does not return to normal.


In GNU Emacs 25.3.1 (x86_64-w64-mingw32)
of 2017-09-27 built on LAPHROAIG
Windowing system distributor 'Microsoft Corp.', version 10.0.15063
Configured using:
'configure --without-dbus --without-compress-install 'CFLAGS=-O2
-static -g3' PKG_CONFIG_PATH=/mingw64/lib/pkgconfig'

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS

Important settings:
  value of $LANG: CHS
  locale-coding-system: cp936

Major mode: IBuffer

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Formats have changed, recompiling...done
Updating buffer list...done
Commands: m, u, t, RET, g, k, S, D, Q; q to quit; h for help
Sorting order reversed
Sorting order normal
Sorting order reversed
Sorting order normal
Making completion list...
Quit
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu
cl-loaddefs pcase cl-lib mail-prsvr mail-utils ibuf-ext ibuffer
time-date mule-util china-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table
w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote w32notify w32 multi-tty
make-network-process emacs)

Memory information:
((conses 16 95668 11237)
(symbols 56 20053 0)
(miscs 48 55 117)
(strings 32 17286 3515)
(string-bytes 1 471856)
(vectors 16 13646)
(vector-slots 8 489273 9496)
(floats 8 160 60)
(intervals 56 403 0)
(buffers 976 19))


[-- Attachment #2: Type: text/html, Size: 9388 bytes --]

bug#30129:

[Windy Tusooa]

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

It happens only when sorting by recency. Does ibuffer re-visit the buffers when re-displaying them?

[-- Attachment #2: Type: text/html, Size: 606 bytes --]

bug#30129: 25.3; ibuffer sorting order does not return to normal after using `ibuffer-invert-sorting' twice

[Lars Ingebrigtsen]

Windy Tusooa <tusooa@vista.aero> writes:

> In ibuffer-mode, the command `ibuffer-invert-sorting’ reverse the
> order of buffers.  But when the command is used the second time, the
> order does not return to normal.

If you call it three times, it does return to normal.  :-)  Until you
hit `g' again.

This should now work better in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#30129: 25.3; ibuffer sorting order does not return to normal after using `ibuffer-invert-sorting' twice

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Windy Tusooa <tusooa@vista.aero> writes:
>
>> In ibuffer-mode, the command `ibuffer-invert-sorting’ reverse the
>> order of buffers.  But when the command is used the second time, the
>> order does not return to normal.
>
> If you call it three times, it does return to normal.  :-)  Until you
> hit `g' again.
>
> This should now work better in Emacs 28.

Uhm, not really -- the problem is that every time ibuffer-redisplay is
called, the order is inverted...  since there is no explicit `recency'
sorter.

I've now added such a sorter, and that fixes the problem.  However, this
effectively reverts e782065477917c10759d618e43b2ec18330ffae3, which made
calling `ibuffer-do-sort-by-recency' twice (permanently) reverse the
sorting order...  which I think is pretty odd, since there's already a
command for that.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no