From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phillip Lord Newsgroups: gmane.emacs.devel Subject: Re: [feature/native-comp] breakage on build Date: Tue, 09 Feb 2021 22:38:55 +0000 Message-ID: <877dng988w.fsf@russet.org.uk> References: <87lfca7lsb.fsf@russet.org.uk> <87im7799s9.fsf@russet.org.uk> <87wnvn5yoz.fsf@russet.org.uk> <87eehuomn2.fsf@russet.org.uk> <83lfc2px16.fsf@gnu.org> <87czxe45f8.fsf@russet.org.uk> <8335yap6p8.fsf@gnu.org> <87wnvm2nhb.fsf@russet.org.uk> <83wnvlod0k.fsf@gnu.org> <87wnvlmjxo.fsf@russet.org.uk> <83ft29nwc0.fsf@gnu.org> <87y2fzr8ve.fsf@russet.org.uk> <87ft26pxra.fsf@russet.org.uk> <877dnipqfh.fsf@russet.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40367"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Stefan Monnier , "Andrea Corallo via Emacs development discussions." To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 09 23:41:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9bhE-000AQH-QM for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Feb 2021 23:41:24 +0100 Original-Received: from localhost ([::1]:47576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9bhC-0002ky-FE for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Feb 2021 17:41:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9bfg-0002Ht-MF for emacs-devel@gnu.org; Tue, 09 Feb 2021 17:39:48 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:35430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9bfe-0005z8-1M; Tue, 09 Feb 2021 17:39:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RXpHVPaILliOg7zJRC5WbbxnRLwr1d94eCOn0OgIGLI=; b=gzMztTS4bVb0B9Y5+9gDcA3rB0 yQsyf3xusawjqtTIlviD79sDyKEa9iFyeOYDUgfKeRMCa3vyxB+xpaH5KuI96mxfu6ygFoUuQAlj7 M4Ta9rbK1pf33vDwgC4Y97SZaCr7Y3vEfY1AVkwqBRYhgpbHpD9nP+lOlIpTRQhEd5LwGPIm8iOYV uC9FTyApNW9ggaNxLVRMpH4nPVNbWirUqrhnYsYOUsaN9CsJnRzkcYNzfL/CmjMhXQvlhDzcS0SAU 6KuP3DDqBnWg/NZZ1IUn7xEU0YfUSq70gXN1sUmj+oRcDzNkmE2yVMgWU+043wEREZzkOyRoAM893 CBsITIfw==; Original-Received: from cpc142648-benw12-2-0-cust627.16-2.cable.virginm.net ([82.10.74.116]:58048 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9beq-00087R-Rc; Tue, 09 Feb 2021 22:38:56 +0000 In-Reply-To: (Andrea Corallo's message of "Tue, 09 Feb 2021 08:25:32 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk Received-SPF: none client-ip=78.129.138.110; envelope-from=phillip.lord@russet.org.uk; helo=cloud103.planethippo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264252 Archived-At: Andrea Corallo writes: > Stefan Monnier writes: > >>> - With native code you can redefine all of these except for the (very >>> few) primitives we open-code directly in the generated code. This is >>> a smaller set than the previous one but still not perfect. >> >> But if we can't build trampolines, currently, the situation is much >> worse: many calls to native-compiled Lisp functions from native-compiled= Lisp >> functions can't be advised any more. > > Correct, but if we can build eln files during the initial compilation we > can also build trampolines AOT. This is just a matter of running: > > (mapatoms (=CE=BB (s)=20=20=20=20 > (when (subr-primitive-p (symbol-function s)) > (comp-trampoline-compile s)))) > > Probably we should wire this in the build system so it's accessible as > make target? Why not wire it into the AOT compilation always? Obviously, if it doubles the AOT compilation, that might not be such a great idea, but otherwise? Phil