all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: haj@posteo.de (Harald Jörg)
Cc: 46574@debbugs.gnu.org
Subject: bug#46574: cperl-mode: Improve detection of entries for imenu [PATCH]
Date: Wed, 17 Feb 2021 00:03:12 +0100	[thread overview]
Message-ID: <877dn7r4y7.fsf@gnus.org> (raw)
In-Reply-To: <871rdffwtr.fsf@hajtower> ("Harald Jörg"'s message of "Tue, 16 Feb 2021 23:54:08 +0100")

haj@posteo.de (Harald Jörg) writes:

> This patch helps CPerl mode to detect various declarations which should
> go into the imenu index but were missed, and also prevents some false
> positives from being included.  Undetected package declarations also led
> to wrong namespace attributions for subroutines declared within those
> packages.

I've only skimmed the patch, but it makes sense to me.  When applying
it, though, patch said:

patching file lisp/progmodes/cperl-mode.el
Hunk #2 succeeded at 1210 (offset -41 lines).
Hunk #3 succeeded at 1367 (offset -41 lines).
Hunk #4 succeeded at 5286 (offset -41 lines).
Hunk #5 succeeded at 5368 (offset -41 lines).
Hunk #6 succeeded at 5403 (offset -41 lines).
Hunk #7 succeeded at 6734 (offset -41 lines).

Which is odd.  Could you check whether the patch is against the current
Emacs trunk?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-02-16 23:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 22:54 bug#46574: cperl-mode: Improve detection of entries for imenu [PATCH] Harald Jörg
2021-02-16 23:03 ` Lars Ingebrigtsen [this message]
2021-02-16 23:48   ` Harald Jörg
2021-02-16 23:56     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dn7r4y7.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=46574@debbugs.gnu.org \
    --cc=haj@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.