* bug#23569: thing-at-point, source of slowness
@ 2016-05-18 7:59 Andreas Röhler
2016-05-18 17:52 ` Eli Zaretskii
2021-07-08 0:49 ` Lars Ingebrigtsen
0 siblings, 2 replies; 6+ messages in thread
From: Andreas Röhler @ 2016-05-18 7:59 UTC (permalink / raw)
To: 23569
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
in thingatpt.el:
;; The function bounds-of-thing-at-point finds the beginning and end
;; positions by moving first forward to the end of the "thing", and then
;; backwards to the beginning.
;;;;;;;
Also *bounds-of-thing-at-point jumps to-and-fro, doing some sanity check
every time.
Suggest to jump ***first *at the beginning, as backward move might be slow.
Avoid to-and-fro, deliver tests instead, so first try will be reliable
or return nil.
*
[-- Attachment #2: Type: text/html, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23569: thing-at-point, source of slowness
2016-05-18 7:59 bug#23569: thing-at-point, source of slowness Andreas Röhler
@ 2016-05-18 17:52 ` Eli Zaretskii
2016-05-23 6:42 ` Andreas Röhler
2021-07-08 0:49 ` Lars Ingebrigtsen
1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2016-05-18 17:52 UTC (permalink / raw)
To: Andreas Röhler; +Cc: 23569
> From: Andreas Röhler <andreas.roehler@easy-emacs.de>
> Date: Wed, 18 May 2016 09:59:41 +0200
>
> Suggest to jump first at the beginning, as backward move might be slow.
Can you tell why? AFAIK, moving back is no slower than moving
forward.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23569: thing-at-point, source of slowness
2016-05-18 17:52 ` Eli Zaretskii
@ 2016-05-23 6:42 ` Andreas Röhler
0 siblings, 0 replies; 6+ messages in thread
From: Andreas Röhler @ 2016-05-23 6:42 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 23569
On 18.05.2016 19:52, Eli Zaretskii wrote:
>> From: Andreas Röhler <andreas.roehler@easy-emacs.de>
>> Date: Wed, 18 May 2016 09:59:41 +0200
>>
>> Suggest to jump first at the beginning, as backward move might be slow.
> Can you tell why? AFAIK, moving back is no slower than moving
> forward.
Referring to non-greedy behaviour of re-search-backward. Which requires
additional checks WRT to a greedy-like match.
After all, it doesn't seem that important, as implemented forms don't
use re-search.
Remains the to-and-fro issue.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23569: thing-at-point, source of slowness
2016-05-18 7:59 bug#23569: thing-at-point, source of slowness Andreas Röhler
2016-05-18 17:52 ` Eli Zaretskii
@ 2021-07-08 0:49 ` Lars Ingebrigtsen
2021-07-08 5:41 ` Andreas Röhler
1 sibling, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-08 0:49 UTC (permalink / raw)
To: Andreas Röhler; +Cc: 23569
Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
> in thingatpt.el:
>
> ;; The function bounds-of-thing-at-point finds the beginning and end
> ;; positions by moving first forward to the end of the "thing", and then
> ;; backwards to the beginning.
>
> ;;;;;;;
>
> Also bounds-of-thing-at-point jumps to-and-fro, doing some sanity check every
> time.
>
> Suggest to jump first at the beginning, as backward move might be slow.
>
> Avoid to-and-fro, deliver tests instead, so first try will be reliable or
> return nil.
(I'm going through old bug reports that unfortunately got little response at
the time.)
I'm not sure I understand the issue, even with the response you gave to
Eli at the time.
Do you have a test case that demonstrates this slowness, and an example
of how you'd change the code?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23569: thing-at-point, source of slowness
2021-07-08 0:49 ` Lars Ingebrigtsen
@ 2021-07-08 5:41 ` Andreas Röhler
2021-07-08 12:40 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Röhler @ 2021-07-08 5:41 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 23569
On 08.07.21 02:49, Lars Ingebrigtsen wrote:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>> in thingatpt.el:
>>
>> ;; The function bounds-of-thing-at-point finds the beginning and end
>> ;; positions by moving first forward to the end of the "thing", and then
>> ;; backwards to the beginning.
>>
>> ;;;;;;;
>>
>> Also bounds-of-thing-at-point jumps to-and-fro, doing some sanity check every
>> time.
>>
>> Suggest to jump first at the beginning, as backward move might be slow.
>>
>> Avoid to-and-fro, deliver tests instead, so first try will be reliable or
>> return nil.
> (I'm going through old bug reports that unfortunately got little response at
> the time.)
>
> I'm not sure I understand the issue, even with the response you gave to
> Eli at the time.
>
> Do you have a test case that demonstrates this slowness, and an example
> of how you'd change the code?
>
Thanks for your care. Don't think it's worth digging into that after
that long time. Suggest to close.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23569: thing-at-point, source of slowness
2021-07-08 5:41 ` Andreas Röhler
@ 2021-07-08 12:40 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-08 12:40 UTC (permalink / raw)
To: Andreas Röhler; +Cc: 23569
Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
> Thanks for your care. Don't think it's worth digging into that after
> that long time. Suggest to close.
OK; done.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-08 12:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-18 7:59 bug#23569: thing-at-point, source of slowness Andreas Röhler
2016-05-18 17:52 ` Eli Zaretskii
2016-05-23 6:42 ` Andreas Röhler
2021-07-08 0:49 ` Lars Ingebrigtsen
2021-07-08 5:41 ` Andreas Röhler
2021-07-08 12:40 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.