From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49609: [PATCH] Add option for handling SGR control sequences in compilation-mode Date: Tue, 20 Jul 2021 13:35:06 +0200 Message-ID: <877dhli5g5.fsf@gnus.org> References: <87a6mkohob.fsf@ya.ru> <877dhooh5w.fsf@ya.ru> <875yx8v5i9.fsf@gnus.org> <87tuksmou1.fsf@ya.ru> <83o8b02jx3.fsf@gnu.org> <87zguio1ex.fsf@gnus.org> <834kcq71eu.fsf@gnu.org> <87zguijo4t.fsf@gnus.org> <83v9565kdk.fsf@gnu.org> <87tukqi6q0.fsf@gnus.org> <874kcqm0vy.fsf@ya.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27853"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49609@debbugs.gnu.org To: Ivan Sokolov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 20 13:36:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5o2i-00074w-6U for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jul 2021 13:36:08 +0200 Original-Received: from localhost ([::1]:39218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5o2h-0001sp-89 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jul 2021 07:36:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o2b-0001sg-W8 for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 07:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5o2b-0005do-Oo for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 07:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5o2b-000816-NW for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 07:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jul 2021 11:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49609 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49609-submit@debbugs.gnu.org id=B49609.162678091830754 (code B ref 49609); Tue, 20 Jul 2021 11:36:01 +0000 Original-Received: (at 49609) by debbugs.gnu.org; 20 Jul 2021 11:35:18 +0000 Original-Received: from localhost ([127.0.0.1]:32975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5o1u-0007zy-2D for submit@debbugs.gnu.org; Tue, 20 Jul 2021 07:35:18 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:56216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5o1r-0007zc-FN for 49609@debbugs.gnu.org; Tue, 20 Jul 2021 07:35:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2TxW0v14+3tIt9p4IeOG20V/MbXyh+6dwFxtbU5tSRs=; b=Y9wxCcva7qk2OyrQ2roMMLY9Mt 2occ14ChqRLSDL996wfp6USVdrjnoITgT3iyQ8aUIDMQvdZ+TI4UZpVpUryE4qYS7bl+js07wemXQ YreE6xHyARVYfb6b3OtXh6rvaCE1B0Xhq2FhzrT2VNOujU9n2XAivD7idynukTKjiPWQ=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5o1i-0002YS-UW; Tue, 20 Jul 2021 13:35:09 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXOzbqcgVtSVEj/ //8/vFkLAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UHFAsiMR0/lbIAAAF3SURBVCjPbdLBSgMxEADQ iWwW9NRCV1jPIvgXu8X2HCETMCcFW9h8RS9ePFVoevDUym4x85XOpC0iuBDIyyQzs9kF+OeZnCc1 QGUe9OsZ2hbVMVhbUFbVOgMt6M34dIpRWbBgAApoka1wtuazjcKxMwrnO4DLBlCHBu6vGVcMPDSq RoY2DN+3Vp0xPLYr1/MZAw4Nqgxt4QYbNSqu+rytRu7nhhjFBPQTXOzuwkaKgsbm4dl9ckS1oKJp bklQvME0IhCR1PloVbQXRyhrdMR5Goi7LvG2RMS0D7ItJscISeroSDQw+gwk6hm7aUagYeZo4U6R 1HYh+F/49HkCzTq/PXCjhQC7bnmQRq+JIro+0IjhBH7t93y5WjDrXpbWHDHoxbJPq5xtayt0Q5C7 7ogy3vnT6UDpPnD670lG9AtG4tTa0xoHwS6jt3mbpOY1lJY2DV/8UnojjnGdkouS5yGvXcpky+PA dUo6Rr6S1FmE2FW0dZu/v9YPH/Cx7EWakAAAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDctMjBU MTE6MzQ6NDkrMDA6MDBE9KwfAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA3LTIwVDExOjM0OjQ5 KzAwOjAwNakUowAAAABJRU5ErkJggg== X-Now-Playing: Four Tet's _Sixteen Oceans_: "4T Recordings" In-Reply-To: <874kcqm0vy.fsf@ya.ru> (Ivan Sokolov's message of "Tue, 20 Jul 2021 00:47:45 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210327 Archived-At: Ivan Sokolov writes: >> I wonder whether `ansi-color-compilation-filter' should be in >> `compilation-filter-hook' by default? > > I don't think so. Well designed (machine readable) output can be parsed > and colored by compilation-mode itself, this filter is most usable in > two cases. > > First, if the output is exclusively human readable and cannot be parsed, > it would be nice to have at least a native coloring. Examples: Elixir. > > Second, if the output is machine redable, but the tool cannot detect > that the terminal is non-interactive and/or it does not have an option > to turn off colorization, `filter' will allow compilation-mode to > process the output. OK; makes sense. Thanks for the explanation. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no