From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Bozhidar Batsov" <bozhidar@batsov.dev>
Cc: 32496@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
Artur Malabarba <bruce.connor.am@gmail.com>,
Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#32496: 27.0.50; Strange indentation when ruby-align-chained-calls is t
Date: Thu, 02 Sep 2021 08:55:50 +0200 [thread overview]
Message-ID: <877dfzcvpl.fsf@gnus.org> (raw)
In-Reply-To: <d816c696-8552-482f-b5b1-ba50bae15fc9@www.fastmail.com> (Bozhidar Batsov's message of "Wed, 01 Sep 2021 13:02:56 +0300")
"Bozhidar Batsov" <bozhidar@batsov.dev> writes:
> Ah, I finally understood the issue at hand! It's really hard to discuss
> indentation problems in e-mail. :D
>
> Yeah, I can confirm there's a bug when using (setq ruby-align-chained-calls t)
> in this example:
>
> some_variable.where.not(x: nil)
> .where(y: 2)
>
> The two `where`s should be lined up, but currently the second `where` is
> lined up with the `not`.
So this is coming from:
('(:before . ".")
(if (smie-rule-sibling-p)
(and ruby-align-chained-calls 0)
(smie-backward-sexp ".")
(cons 'column (+ (current-column)
ruby-indent-level))))
In the aligned case, I think we should back up to the first "." in the
chain and use that as the column? But my SMIE-fu is pretty much
non-existent, so I've added Stefan to the CCs.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-09-02 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 11:36 bug#32496: 27.0.50; Strange indentation when ruby-align-chained-calls is t Artur Malabarba
2018-08-22 12:50 ` Dmitry Gutov
2018-10-27 22:22 ` Artur Malabarba
2018-11-18 8:36 ` Bozhidar Batsov
2021-09-01 9:53 ` Lars Ingebrigtsen
2021-09-01 10:02 ` Bozhidar Batsov
2021-09-02 6:55 ` Lars Ingebrigtsen [this message]
2021-09-08 19:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 14:25 ` Lars Ingebrigtsen
2020-09-11 17:16 ` Wendel Scardua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dfzcvpl.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=32496@debbugs.gnu.org \
--cc=bozhidar@batsov.dev \
--cc=bruce.connor.am@gmail.com \
--cc=dgutov@yandex.ru \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.