From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34268: 27.0.50; wrong indentation in python mode Date: Wed, 22 Sep 2021 23:57:52 +0200 Message-ID: <877df8qnmn.fsf_-_@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35284"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 34268@debbugs.gnu.org, sds@gnu.org, Augusto Stoffel To: Valentin Ignatev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 22 23:59:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTAGm-0008vX-OO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 23:59:12 +0200 Original-Received: from localhost ([::1]:53676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTAGk-0005GQ-0B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 17:59:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTAGd-0005F7-1x for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 17:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTAGc-0000FC-Qe for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 17:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTAGb-0003UL-P4 for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 17:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Sep 2021 21:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34268-submit@debbugs.gnu.org id=B34268.163234788613320 (code B ref 34268); Wed, 22 Sep 2021 21:59:01 +0000 Original-Received: (at 34268) by debbugs.gnu.org; 22 Sep 2021 21:58:06 +0000 Original-Received: from localhost ([127.0.0.1]:52014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTAFh-0003Sl-Sn for submit@debbugs.gnu.org; Wed, 22 Sep 2021 17:58:06 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTAFg-0003SC-0w for 34268@debbugs.gnu.org; Wed, 22 Sep 2021 17:58:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VLhHuHU+w3QT74wJjUGjwL0lqCB/adIQrL6O6gvQfCM=; b=HSA5bUqFVi0Kv08scfDmpIpFBp pF103KXvgHecO4ivazOdvOcw4o8ziTMuLi+cv0PiCv1LNRZuBoelftxc5/8Lrsm/eOllGa+NKK0GB I2SFc3e4djE8osxIvIH2PhaLhfQH9klrfAosIQ2S3SlqIH66m6hbmnqasLobyXbDUBJU=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTAFU-0007kW-Vb; Wed, 22 Sep 2021 23:57:56 +0200 X-Now-Playing: Was (Not Was)'s _Wheel Me Out_: "Wheel Me Out" In-Reply-To: (Valentin Ignatev's message of "Mon, 10 Jun 2019 00:24:28 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215144 Archived-At: Valentin Ignatev writes: > Hey Sam, I've looked in the python.el code and it seems that it reuses > python-indent-def-block-scale for calculating an indentation. > > The default value is 2 which is why inside-parens indent doubles. Setting its > value to 1 fixes the issue. > > I also wonder why authors choose double indent for aligning function > arguments. Is this some kind of an oldschool code style? :) (I'm going through old bug reports that unfortunately weren't resolved at the time.) If I understand correctly (and I may well not -- I don't write much python), this is just a preference issue, and setting `python-indent-def-block-scale' to 1 fixes the issue? If that's what's recommended by the standards, should we flip the default to 1? I've added Augusto to the CCs; perhaps he has an opinion here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no