From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50851: 28.0.50; flyspell-mode overrides context-menu-mode Date: Tue, 28 Sep 2021 22:01:03 +0300 Organization: LINKOV.NET Message-ID: <877df0le34.fsf@mail.linkov.net> References: <87fstqxbrm.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35818"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 50851@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 28 21:07:58 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVISM-00095a-3v for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 21:07:58 +0200 Original-Received: from localhost ([::1]:43060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVISK-00060K-8t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 15:07:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVIPY-00024B-7m for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 15:05:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVIPX-0004AN-Tx for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 15:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVIPX-0005ZH-P1 for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 15:05:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Sep 2021 19:05:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50851 X-GNU-PR-Package: emacs Original-Received: via spool by 50851-submit@debbugs.gnu.org id=B50851.163285588821354 (code B ref 50851); Tue, 28 Sep 2021 19:05:03 +0000 Original-Received: (at 50851) by debbugs.gnu.org; 28 Sep 2021 19:04:48 +0000 Original-Received: from localhost ([127.0.0.1]:47001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVIPH-0005YF-JK for submit@debbugs.gnu.org; Tue, 28 Sep 2021 15:04:47 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVIP7-0005XT-FJ for 50851@debbugs.gnu.org; Tue, 28 Sep 2021 15:04:38 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id A22C4C0002; Tue, 28 Sep 2021 19:04:30 +0000 (UTC) In-Reply-To: <87fstqxbrm.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 27 Sep 2021 15:45:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215791 Archived-At: > When clicking on a misspelled word while context-menu-mode is active, > I'd expect the context menu to appear, but it seems like flyspell > prevents this. It was a bug caused by recent changes that is fixed now. > Asides from preventing this inconsistency, it seems like it would be > better to integrate flyspell into context-menu, to suggest corrections. Adapting flyspell.el to context-menu is a welcome change that requires refactoring `flyspell-correct-word' and related functions to return a keymap menu where every menu item is bound to a lambda that calls `flyspell-do-correct' with an argument that is a correct word.