From: Michael Heerdegen <michael_heerdegen@web.de>
To: Robert Irelan <rirelan@gmail.com>
Cc: 51140@debbugs.gnu.org
Subject: bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins)
Date: Tue, 12 Oct 2021 04:50:33 +0200 [thread overview]
Message-ID: <877dejgdmu.fsf@web.de> (raw)
In-Reply-To: <CAJUyYjo9UYOhQCgfbZh9pa4RtXpfMOBFgeLZo=c6mCv4aDWPzQ@mail.gmail.com> (Robert Irelan's message of "Mon, 11 Oct 2021 19:40:54 -0700")
Robert Irelan <rirelan@gmail.com> writes:
> (defun +ivy--always-return-zero-exit-code-a (fn &rest args)
> (let ((process-exit-status-orig
> (symbol-function 'process-exit-status)))
> (cl-letf* (((symbol-function 'process-exit-status)
> (lambda (_proc)
> (let ((code (funcall process-exit-status-orig proc)))
> (if (= code 2) 0 code)))))
> (apply fn args)))
You didn't touch what I meant: the variable `proc' is free in your
lambda. There is only an argument with the similar name `_prog'. So
that code still looks broken.
Michael.
next prev parent reply other threads:[~2021-10-12 2:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 22:37 bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins) Robert Irelan
2021-10-12 2:30 ` Michael Heerdegen
2021-10-12 2:40 ` Robert Irelan
2021-10-12 2:50 ` Michael Heerdegen [this message]
2021-10-12 2:57 ` Robert Irelan
2021-10-12 22:35 ` Stefan Kangas
2021-10-13 5:13 ` Robert Irelan
2021-10-19 5:31 ` Stefan Kangas
2021-11-30 16:22 ` Andrea Corallo
2022-09-12 11:49 ` Lars Ingebrigtsen
2022-09-14 3:22 ` Robert Irelan
2022-09-14 12:41 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dejgdmu.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=51140@debbugs.gnu.org \
--cc=rirelan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.