all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Lawrence <rwl@recursewithless.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51320@debbugs.gnu.org
Subject: bug#51320: 26.1; kill-region does not ignore its first two args if region is active
Date: Thu, 21 Oct 2021 20:57:17 +0200	[thread overview]
Message-ID: <877de6p5o2.fsf@aquinas.rewrittenlocator.xyz> (raw)
In-Reply-To: <83v91q8gfl.fsf@gnu.org>


>> From: Richard Lawrence <rwl@recursewithless.net>
>> Date: Thu, 21 Oct 2021 14:29:11 +0200
>> 
>> In a function I'm writing, I tried to call kill-region like this:
>> 
>> (and (use-region-p) (kill-region nil nil t))
>> 
>> with its first two arguments being nil, because the docstring says:
>> 
>> "Supply two arguments, character positions BEG and END indicating the
>>  stretch of text to be killed.  If the optional argument REGION is
>>  non-nil, the function ignores BEG and END, and kills the current
>>  region instead."
>> 
>> But in fact, if both BEG and END are nil as in my function call,
>> kill-region doesn't ignore them but throws an error, since its first two
>> lines are:
>> 
>>   (unless (and beg end)
>>     (user-error "The mark is not set now, so there is no region"))
>> 
>> This was surprising to me, since I expected these values to be ignored.

Eli Zaretskii <eliz@gnu.org> writes:

> The error is thrown because there's no region in the buffer where you
> invoke this.  The fact that you pass BEG and END nil is not the reason
> for the error.

Forgive me, I'm no expert, but that doesn't sound right to me, for two
reasons:

1) In my example, kill-region is only called if use-region-p returns t.
(I also checked that (point) and (mark) return non-nil in this
context with the debugger.) 

2) Literally the first and only thing that kill-region does before
throwing the error is check whether BEG and END are non-nil. The error I
see is the one in the unless clause quoted above.

Am I missing something?    

-- 
Best,
Richard





  reply	other threads:[~2021-10-21 18:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 12:29 bug#51320: 26.1; kill-region does not ignore its first two args if region is active Richard Lawrence
2021-10-21 16:56 ` Eli Zaretskii
2021-10-21 18:57   ` Richard Lawrence [this message]
2021-10-21 19:15     ` Eli Zaretskii
2021-10-22  9:34       ` Richard Lawrence

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877de6p5o2.fsf@aquinas.rewrittenlocator.xyz \
    --to=rwl@recursewithless.net \
    --cc=51320@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.