all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Tak Kunihiro <homeros.misasa@gmail.com>
Cc: tkk@misasa.okayama-u.ac.jp, 45915@debbugs.gnu.org
Subject: bug#45915: 28.0.90; deletechar distorts org-table
Date: Sun, 19 Dec 2021 20:53:21 +0800	[thread overview]
Message-ID: <877dc0sqm6.fsf@localhost> (raw)
In-Reply-To: <m1zgpc7qkj.fsf_-_@misasa.okayama-u.ac.jp>

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Tak Kunihiro <homeros.misasa@gmail.com> writes:

> I confirm that there still is the problem with org-table on Emacs
> 28.0.90 pretest with org-version 9.5.1.
>
> Here is a recipe to reproduce the problem.  I still have to stick to
> 26.3.

I was able to reproduce. Can you try the attached fix?

Best,
Ihor


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-table.el-Fix-orgtbl-mode-not-remapping-delete-ke.patch --]
[-- Type: text/x-diff, Size: 1090 bytes --]

From 7b1a7d43e090292b6bd821c65a644f8c599b2044 Mon Sep 17 00:00:00 2001
Message-Id: <7b1a7d43e090292b6bd821c65a644f8c599b2044.1639918362.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Sun, 19 Dec 2021 20:49:54 +0800
Subject: [PATCH] org-table.el: Fix orgtbl-mode not remapping delete key

* lisp/org-table.el (orgtbl-setup): Remap `delete-forward-char' in
addition to `deleta-char'.  The former is called in Emacs >26.

Fixes https://orgmode.org/list/1AD1B9B7-5A15-4F86-9274-B04B83694C85@misasa.okayama-u.ac.jp
---
 lisp/org-table.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index 1546cd563..0560e32a1 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -5290,6 +5290,7 @@ (defun orgtbl-setup ()
       (org-remap orgtbl-mode-map
 		 'self-insert-command 'orgtbl-self-insert-command
 		 'delete-char 'org-delete-char
+                 'delete-forward-char 'org-delete-char
 		 'delete-backward-char 'org-delete-backward-char)
       (org-defkey orgtbl-mode-map "|" 'org-force-self-insert))
     t))
-- 
2.32.0


  reply	other threads:[~2021-12-19 12:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16  8:01 bug#45915: 27.1; deletechar distorts org-table Tak Kunihiro
2021-01-31  2:54 ` bug#45915: 27.1.91; " Tak Kunihiro
2021-04-28  6:03   ` Bastien
2021-04-28  8:36     ` bug#45915: 27.2; " Tak Kunihiro
2021-10-11  0:45       ` bug#45915: 29.0.50; " Tak Kunihiro
2021-12-07  8:43         ` bug#45915: 28.0.90; " Tak Kunihiro
2021-12-19 12:53           ` Ihor Radchenko [this message]
2021-12-29  6:28             ` Tak Kunihiro
2022-04-30  4:00               ` Ihor Radchenko
2022-05-23  9:26                 ` Tak Kunihiro
2022-05-23  9:55                   ` Ihor Radchenko
2022-06-18  6:20                     ` Ihor Radchenko
2022-04-30  4:00               ` Ihor Radchenko
2022-07-13 10:17                 ` bug#45915: 28.1; delete-char deletes two letters Tak Kunihiro
2022-09-15  9:30                   ` bug#45915: 28.2; " Tak Kunihiro
2022-09-16  3:59                     ` Ihor Radchenko
2022-09-17  3:48                     ` Tak Kunihiro
2022-09-17  6:38                       ` Eli Zaretskii
2022-09-17  8:20                         ` Tak Kunihiro
2022-09-17 11:17                           ` Eli Zaretskii
2022-09-18  5:44                             ` Tak Kunihiro
2022-09-18  5:56                               ` Eli Zaretskii
2022-09-18  8:05                                 ` Eli Zaretskii
2022-09-19  1:02                                   ` Tak Kunihiro
2022-09-22 12:03                                   ` Ihor Radchenko
2022-09-22 12:46                                     ` Eli Zaretskii
2022-09-22 12:46                                       ` Eli Zaretskii
2022-09-22 21:36                                       ` Tak Kunihiro
2022-09-23  6:02                                         ` Eli Zaretskii
2022-09-23  6:02                                         ` Eli Zaretskii
2022-09-22 21:36                                       ` Tak Kunihiro
2022-09-22 12:03                                   ` Ihor Radchenko
2022-09-19  1:24                                 ` Tak Kunihiro
2022-09-19 13:27                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dc0sqm6.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=45915@debbugs.gnu.org \
    --cc=homeros.misasa@gmail.com \
    --cc=tkk@misasa.okayama-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.