From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems Date: Wed, 16 Feb 2022 21:40:57 +0800 Message-ID: <877d9vudxy.fsf@yahoo.com> References: <83czjqrkew.fsf@gnu.org> <874k52kiu4.fsf@yahoo.com> <837d9yribj.fsf@gnu.org> <87v8xii83e.fsf@yahoo.com> <83r186p1h8.fsf@gnu.org> <878ruehx6n.fsf@yahoo.com> <83h791pmnl.fsf@gnu.org> <87iltheyeu.fsf@yahoo.com> <83wnhwol2o.fsf@gnu.org> <87tud0ybhj.fsf@yahoo.com> <837d9w450e.fsf@gnu.org> <87czjow7x1.fsf@yahoo.com> <8335kk440x.fsf@gnu.org> <87sfsjvdnm.fsf@yahoo.com> <87leybv8mp.fsf@yahoo.com> <87h78zv1hc.fsf@yahoo.com> <83fsoj2e7m.fsf@gnu.org> <87v8xfuh2z.fsf@yahoo.com> <83bkz72dhh.fsf@gnu.org> <87pmnnuflf.fsf@yahoo.com> <837d9v2axs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36820"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 16 14:43:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKKaM-0009Qg-RD for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Feb 2022 14:43:10 +0100 Original-Received: from localhost ([::1]:33246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKKaL-0001Nm-CV for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Feb 2022 08:43:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKKYX-0008Be-C3 for emacs-devel@gnu.org; Wed, 16 Feb 2022 08:41:21 -0500 Original-Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:35320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKKYU-0004CU-75 for emacs-devel@gnu.org; Wed, 16 Feb 2022 08:41:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1645018869; bh=xGl3QvmPl9E/nWVX5IVUO/kqziNalC6NIE+gq3wazcE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=RdFJI5Z/KCsamnQR1+qBmVTb/VmQNn3L0KAfc6JwVRJx41m5IrkqexZNKc10U4ksCRyhcFrQo38zi+KIJebEA1iG6351ijXM9K8OlvnITvQkDc3AAJ1G+8ZsUOixq5pJwKVjNxn8/EzIFBUNdxpWJzMqi0/0AWy8Tys5kmcFr2p6S5Zat3T6q1r6fzC2r5JtfMhmrFxDL2PJM0cYpeBGhVQ43ZG3VAYly4QB5EsQpAvOvgdutJ5HtUHILjUS+UF2B6ITvhD3QWKs8b+3/4Uw/o9lfifFYVARc50JiOkvkuLREsihlLTqUgzvdsuKnnjUx+mE50FDtLzWBnMnXadNjQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1645018869; bh=YWy3JOJ1pMzsuTdWZQZ/ri83GIW1Un+JEdplEB8HVlW=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=WNEa/kVlrB4NNN+4mYjYZ3kW1igFOa4hGHAt8mFqYhlRxICujgNrtZZGq4BD2tIufd5wDENmApkOr9YI6bj0Vk1g3cgzUhdzTXQ4UNn4MTxj5dUgU1SlZdN0WJgtxxNGGjlxMZEz6tF68Cy6Bq5fCsZRdaGUuXMODypZsUjs7W5nZAeHhYbmmCumsYNnen8HGYD7Hyfea7f4g2hG6GHDE+a3LaFau/oBcZaSW0ycTehrx+63gN9vAw4Tr1QpwoIw984KtzJEiNj6LUFQmQK8LVLQWi7rDcRfH6LS+MFn2vfGqmZ9JHdzOX7RPv5IHkdocCZw0yb2LyQiP1CAeLyEjA== X-YMail-OSG: liP.9e4VM1k0TpE8vya4Lww5khMzDt.2.FieGwsXfVQl8npPOfRwLcAkR19DLl7 3xMrDQ2xviAySjdHAGJT1xJ5uVEnWW1HPagi3p4ZdaoFdq6.J1V.hG5CvsOEfunPGx2l6hcAGJ0L Lex7pchsui.MWjwaHuBtbiLjhzw_.5t9ULsIorXgAmCgxNA90fwsERaadmgicgaEG6scjNdnGXiF 8sQ22pQp0rZv8CEXSxSzQIWQaYPBB7mDUnViToLaeUcpvErd_yGelnjcISSMNroT.b8W.XOKJs5l PaEmRMSBg1MHpg_sSYpUzgrGbZvteMuTprovRlIEkNsW9fqYTodHcw5OySMvMEMmPF8MANbvMkY_ yRNfJPdVekka_LhfwCgmXnrtZ6JPpASmMsVlFlNS8Q4ToSH9TQFMIzF.7qUem_0J6wgbVQpOk9vg rIbFCuuhY8VRmOaoQu1Taytn8SS2uG6I9zb7mm0q7gTusv6djjVRwc6b4GvP4hDg3bJ9SITNMgKw hK30gexYQjPrmSuOqY1Wf80nQnV3_vQhxZ8gjBxGLiBl11y8ouohjVflZi4t1l8yidFKISlEmUQO Swj6J4A_RGos9y9UA7Q6n4b3L.3QDK6kN5jtzwKULbjl76Azrv_v0.3eqprpUcPbCezQkFaX.iOs a70kbaq1RsAl.3NMnkcyzzpULwucy0P45NuEujBXw9mAKcbUhigxVX.kz9T4gi0PMa9MzJgiCRia lHBIytft12AF8Zq920i9t5leCiHwaasdCv4beMUytLLFaJIiVqAVMzoioh.PU9P12qPTkuH1w5eT cVtzhIhcTNF.AJGd06ld9lPU9fGWWaaZwHU9IxJD7n X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Wed, 16 Feb 2022 13:41:09 +0000 Original-Received: by kubenode501.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID ecd98d4ab021752ff890797f08c24b6e; Wed, 16 Feb 2022 13:41:03 +0000 (UTC) In-Reply-To: <837d9v2axs.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 16 Feb 2022 15:33:19 +0200") X-Mailer: WebService/1.1.19724 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.204; envelope-from=luangruo@yahoo.com; helo=sonic311-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286388 Archived-At: Eli Zaretskii writes: > I guess I don't understand what you want to install. Can you show a > patch? Sure, thanks: diff --git a/src/xterm.c b/src/xterm.c index b55a54b945..9fa725e9f3 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -8734,6 +8734,15 @@ handle_one_xevent (struct x_display_info *dpyinfo, { /* Decode the input data. */ +#ifdef HAVE_GLIB + /* If this isn't done in a build with GLib (usually + with GTK), then the resulting signal in + `setup_coding_system' will cause Emacs to + crash. */ + if (NILP (Fcoding_system_p (coding_system))) + goto done_keysym; +#endif + /* The input should be decoded with `coding_system' which depends on which X*LookupString function we used just above and the locale. */