From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54369: 28.0.92; [PATCH] Fix negated argument predicates in Eshell Date: Sun, 13 Mar 2022 15:38:09 +0100 Message-ID: <877d8xvrxq.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13059"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54369@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 13 15:39:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTPNR-0003Cg-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Mar 2022 15:39:21 +0100 Original-Received: from localhost ([::1]:50706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTPNP-0003cw-Oo for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Mar 2022 10:39:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTPN8-0003cR-RR for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 10:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49203) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTPN8-0006G6-JE for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 10:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTPN8-0004Hx-Ez for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 10:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Mar 2022 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54369 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54369-submit@debbugs.gnu.org id=B54369.164718230216421 (code B ref 54369); Sun, 13 Mar 2022 14:39:02 +0000 Original-Received: (at 54369) by debbugs.gnu.org; 13 Mar 2022 14:38:22 +0000 Original-Received: from localhost ([127.0.0.1]:43097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTPMT-0004Gm-S1 for submit@debbugs.gnu.org; Sun, 13 Mar 2022 10:38:22 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTPMR-0004GR-Qu for 54369@debbugs.gnu.org; Sun, 13 Mar 2022 10:38:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BqbVXaXxy9oaeM7zzVlBem+/5bJs86azb56eT9vJCh4=; b=jQQJ8DX+Bl9E8AItOvdbEPZ0Tz bZSeHWtTYkWpr1ZtWdttBJrVaNnThnzmi4HC3Y9jZvIPtvMfCchcT2Txx/cnCC+C7aCCg+J4OhfJm fCT2a28Pqm+TQfDMR7379VmLXh+kMFJASUarTM92YyZoLJFL8vz3l43t6NSXBFZ+XfhM=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTPMI-0003PV-M8; Sun, 13 Mar 2022 15:38:12 +0100 In-Reply-To: (Jim Porter's message of "Sat, 12 Mar 2022 22:34:16 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228297 Archived-At: Jim Porter writes: > I think this is due to the lexical binding change in 28. Attached is a > patch to fix this. No unit tests right now, but I'm working on a patch > for 29 with full unit tests for Eshell globs and argument > predicates/modifiers. (I pulled this bit out of my branch for that, > since it's a regression that should probably get fixed in 28.) Yup. Pushed to emacs-28 now. > Regarding the patch itself, I'm not sure if there's a cleaner way to > do this; it feels like there should be, but this is the only way I > could think of off-hand to fix it. It looks like the most obvious minimal way to fix this to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no