From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 54369@debbugs.gnu.org
Subject: bug#54369: 28.0.92; [PATCH] Fix negated argument predicates in Eshell
Date: Sun, 13 Mar 2022 15:38:09 +0100 [thread overview]
Message-ID: <877d8xvrxq.fsf@gnus.org> (raw)
In-Reply-To: <fca98c56-99e7-bf60-de1d-5ca3f3eef463@gmail.com> (Jim Porter's message of "Sat, 12 Mar 2022 22:34:16 -0800")
Jim Porter <jporterbugs@gmail.com> writes:
> I think this is due to the lexical binding change in 28. Attached is a
> patch to fix this. No unit tests right now, but I'm working on a patch
> for 29 with full unit tests for Eshell globs and argument
> predicates/modifiers. (I pulled this bit out of my branch for that,
> since it's a regression that should probably get fixed in 28.)
Yup. Pushed to emacs-28 now.
> Regarding the patch itself, I'm not sure if there's a cleaner way to
> do this; it feels like there should be, but this is the only way I
> could think of off-hand to fix it.
It looks like the most obvious minimal way to fix this to me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-03-13 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 6:34 bug#54369: 28.0.92; [PATCH] Fix negated argument predicates in Eshell Jim Porter
2022-03-13 14:38 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d8xvrxq.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=54369@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.