From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55204: [PATCH v2] 29.0.50; Improve quoting consistency in Eshell predicates/modifiers Date: Sun, 01 May 2022 20:22:43 +0200 Message-ID: <877d75dsek.fsf@gnus.org> References: <155d0ab6-fe59-940d-23ad-34a6d066fc46@gmail.com> <87fslttzmk.fsf_-_@gnus.org> <88fcb2cf-213f-b1c1-8d95-b71fba5e4055@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36435"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55204@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 01 20:23:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlEE7-0009HB-6g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 20:23:23 +0200 Original-Received: from localhost ([::1]:45066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlEE5-0005Re-Ut for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 14:23:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlEDm-0005PM-6V for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nlEDl-0001fp-UY for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nlEDl-0003XE-RS for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2022 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55204 X-GNU-PR-Package: emacs Original-Received: via spool by 55204-submit@debbugs.gnu.org id=B55204.165142937613564 (code B ref 55204); Sun, 01 May 2022 18:23:01 +0000 Original-Received: (at 55204) by debbugs.gnu.org; 1 May 2022 18:22:56 +0000 Original-Received: from localhost ([127.0.0.1]:34157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlEDg-0003Wi-JU for submit@debbugs.gnu.org; Sun, 01 May 2022 14:22:56 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlEDe-0003WU-CB for 55204@debbugs.gnu.org; Sun, 01 May 2022 14:22:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ap1lXnA7NhRZIhvgo8lums2T2S7XuRM+XZlIom/Ppr8=; b=HirCB+6pa8Qe/tV2R39yXz9nN1 EjZ3XMuHClyblT8Spzq5twLIheB8GV3vPi5vDJruZ6A0XjXEPu6QzHs9jOUrhniKORubbbbYYZnF5 BcIOOknvacs+FYbGFwR5PbFKhuPpVLX3DeeHNl8MVPSwcFFBImfhyIX0IKhN3a3GmQRg=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlEDV-0008SK-1R; Sun, 01 May 2022 20:22:47 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAAAXNSR0IArs4c6QAAAAlQTFRF NjEurZ+U////zOWjqgAAAAFiS0dEAmYLfGQAAAAJcEhZcwAACxIAAAsSAdLdfvwAAAAHdElNRQfm BQESFTabOL65AAAAuklEQVQoz3WQSw7EIAiGIZE9k7T3YZK610Tvf5UB1Mq86KZf/wdWAICz+xSw 6QFwKuIwlRaV9p3pIUO/2gYMCT2P2d4rwC6o7CChbO4ZK98h/VXgEcGkLAt007Wh3mvcVyACTRTN CBroyQVWBIdtQbLqMoHtFsq2UQTMu4Cu0Ea9btvZRdKtNGFagI1HkU/WxaIxk0meekIZNtYHygS9 Lr2W/a/aL+yZJe7BT7g/EAdI0XiESDpKLBB6AZJ2PakqBaeNAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIyLTA1LTAxVDE4OjIxOjU0KzAwOjAwfiN5ygAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0w MVQxODoyMTo1NCswMDowMA9+wXYAAAA4dEVYdGljYzpjb3B5cmlnaHQAQ29weXJpZ2h0IChjKSAx OTk4IEhld2xldHQtUGFja2FyZCBDb21wYW55+Vd5NwAAACF0RVh0aWNjOmRlc2NyaXB0aW9uAHNS R0IgSUVDNjE5NjYtMi4xV63aRwAAACZ0RVh0aWNjOm1hbnVmYWN0dXJlcgBJRUMgaHR0cDovL3d3 dy5pZWMuY2gcfwBMAAAAN3RFWHRpY2M6bW9kZWwASUVDIDYxOTY2LTIuMSBEZWZhdWx0IFJHQiBj b2xvdXIgc3BhY2UgLSBzUkdCRFNIqQAAAABJRU5ErkJggg== X-Now-Playing: Let's Eat Grandma's _Two Ribbons_: "Hall Of Mirrors" In-Reply-To: <88fcb2cf-213f-b1c1-8d95-b71fba5e4055@gmail.com> (Jim Porter's message of "Sun, 1 May 2022 11:18:49 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231188 Archived-At: Jim Porter writes: > I've also moved a stray Eshell entry from the "Lisp Changes" section > into the Eshell subsection of "Changes in Specialized Modes". It was > more of a user-facing change, so it's probably best to put it there > alongside all the other similar changes (I added a pointer to the > manual section too). Thanks; looks good. But this leads to a couple of test failures, like the one below. (Note -- this doesn't fail when "make eshell-tests", but with "make check".) Test eshell-test/redirect-buffer backtrace: signal(ert-test-failed (((should (equal (buffer-string) "hi")) :form ert-fail(((should (equal (buffer-string) "hi")) :form (equal "" "hi" #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name eshell-test/redirect-buffer :document ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [... ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/eshell-tests" command-line() normal-top-level() Test eshell-test/redirect-buffer condition: (ert-test-failed ((should (equal (buffer-string) "hi")) :form (equal "" "hi") :value nil :explanation (arrays-of-different-length 0 2 "" "hi" first-mismatch-at 0))) FAILED 19/25 eshell-test/redirect-buffer (0.001028 sec) at lisp/eshell/eshell-tests.el:117 Test eshell-test/redirect-buffer-escaped backtrace: -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no